Type narrowing of `target: type[T]` using insinstance seems to fool mypy
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 20.6k
- Forks
- 3.3k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug Report
Well, I was writing some sort of converter from unstructured data to a dataclass, so I had a function that uses f[T](obj, target_type: type[T]) -> T and while in the end I stick to typing.cast for that, I also tried several solutions, they are below.
One of them intuitively should(?) work (return_checktype), but mypy refuses to follow them, and one of them is obviously wrong in hindsight (return_checkval), but mypy is happy with it.
To Reproduce
from typing import reveal_type
def return_checkval[T](target_type: type[T]) -> T:
# runtime check that target_type is int
if isinstance(target_type, int):
reveal_type(target_type)
return 42 # and they lived happily ever after
raise ValueError("Unsupported type")
x = return_checkval(int)
print(x)
def return_checktype[T](target_type: type[T]) -> T:
# runtime check that target_type is int
if target_type is int:
reveal_type(target_type)
return 42 # errors here
raise ValueError("Unsupported type")
# example test
x = return_checktype(int)
print(x)
Expected Behavior
At the very least, it should have two reveal_type outputs, and it should reject the first function completely. That's what (based)pyright.
Ideally, it should also allow the second function, but (based)pyright also rejects it :(
Actual Behavior
t.py:20: note: Revealed type is "type[T`-1]"
t.py:21: error: Incompatible return value type (got "int", expected "T") [return-value]
Found 1 error in 1 file (checked 1 source file)
Traceback (most recent call last):
File "/private/tmp/test/t.py", line 13, in <module>
x = return_checkval(int)
File "/private/tmp/test/t.py", line 10, in return_checkval
raise ValueError("Unsupported type")
ValueError: Unsupported type
Your Environment
mypy version 1.19.1 (compiled yes)
python version .. honestly have no idea which one it uses, but python --version is 3.14
just run it mypy . from the folder in /tmp
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza ejecutando el reproductor proporcionado con mypy 1.19.1 y compara los tipos revelados y los diagnósticos con el comportamiento esperado. Sigue el recorrido del estrechamiento de tipos para isinstance(target_type, int) y target_type is int; el trabajo estará terminado cuando se rechace la primera función no válida y el comportamiento de estrechamiento admitido esté cubierto por pruebas de regresión.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- compilers, devtools
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100