python / python/mypy

Assertion failure crash with shadowed functools module: assert isinstance(singledispatch_obj, Instance)

Offen
#20,339 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

crash priority-2-low
Vorherrschende Sprache
Python
Sterne
20.6k
Forks
3.3k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

Crash Report

I noticed this crash when running mypy on the cpython codebase.

Traceback

Traceback (most recent call last):
  File ".venv-mypy/bin/mypy", line 7, in <module>
    sys.exit(console_entry())
  File "mypy/mypy/__main__.py", line 15, in console_entry
    main()
  File "mypy/mypy/main.py", line 127, in main
    res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)
  File "mypy/mypy/main.py", line 211, in run_build
    res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)
  File "mypy/mypy/build.py", line 223, in build
    result = _build(
  File "mypy/mypy/build.py", line 302, in _build
    graph = dispatch(sources, manager, stdout)
  File "mypy/mypy/build.py", line 2953, in dispatch
    process_graph(graph, manager)
  File "mypy/mypy/build.py", line 3344, in process_graph
    done, still_working = manager.wait_for_done(graph)
  File "mypy/mypy/build.py", line 926, in wait_for_done
    process_stale_scc(graph, next_scc, self)
  File "mypy/mypy/build.py", line 3482, in process_stale_scc
    graph[id].type_check_first_pass()
  File "mypy/mypy/build.py", line 2341, in type_check_first_pass
    self.type_checker().check_first_pass()
  File "mypy/mypy/checker.py", line 530, in check_first_pass
    self.accept(d)
  File "mypy/mypy/checker.py", line 641, in accept
    stmt.accept(self)
    ~~~~~~~~~~~^^^^^^
  File "mypy/mypy/nodes.py", line 1164, in accept
    return visitor.visit_decorator(self)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "mypy/mypy/checker.py", line 5466, in visit_decorator
    self.visit_decorator_inner(e)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
  File "mypy/mypy/checker.py", line 5502, in visit_decorator_inner
    sig, t2 = self.expr_checker.check_call(
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        dec, [temp], [nodes.ARG_POS], e, callable_name=fullname, object_type=object_type
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "mypy/mypy/checkexpr.py", line 1589, in check_call
    return self.check_callable_call(
           ~~~~~~~~~~~~~~~~~~~~~~~~^
        callee,
        ^^^^^^^
    ...<6 lines>...
        object_type,
        ^^^^^^^^^^^^
    )
    ^
  File "mypy/mypy/checkexpr.py", line 1832, in check_callable_call
    new_ret_type = self.apply_function_plugin(
        callee,
    ...<7 lines>...
        context,
    )
  File "mypy/mypy/checkexpr.py", line 1270, in apply_function_plugin
    return callback(
        FunctionContext(
    ...<8 lines>...
        )
    )
  File "mypy/mypy/plugins/singledispatch.py", line 109, in create_singledispatch_function_callback
    assert isinstance(singledispatch_obj, Instance)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 
functools.py:4: : note: use --pdb to drop into pdb

To Reproduce

Save the following snippet as functools.py and run mypy on it:

def singledispatch(func):
    pass

@singledispatch
def f(fn):
    pass

Your Environment

  • Mypy version used: 67df1163e5e2d197795811d8083da6afd13fb4f3
  • Mypy command-line flags: N/A
  • Mypy configuration options from mypy.ini (and other config files): N/A
  • Python version used: 3.13.7
  • Operating system and version: Arch Linux

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne mit mypy/plugins/singledispatch.py, insbesondere mit create_singledispatch_function_callback und der im Traceback gezeigten Assertion. Reproduziere den Absturz, indem du das bereitgestellte Snippet als functools.py speicherst und mypy darauf ausführst. Fertig ist die Aufgabe, wenn dieses überschriebene functools-Modul keinen AssertionError mehr verursacht.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
devtools
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.