Lenient TypeVarTuple checking when number of dimensions is unknown
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 20.6k
- Forks
- 3.3k
- Merge medio
- 1 d 18 h
- PR fusionados (30 d)
- 54
Descripción
Currently this generates an error:
from typing import Any
class C[*Ts, S]:
pass
a = C[int, str]()
a = C[*tuple[Any, ...], str]() # Error
This is the output:
error: Incompatible types in assignment (expression has type "C[*tuple[Any, ...], str]", variable has type "C[int, str]")
However, this doesn't generate an error:
from typing import Any
class C[*Ts, S]:
pass
a = C[int, str]()
a = C[*tuple[Any, ...]]() # No error
I'd argue that the first example shouldn't generate an error either. One possible rule would be to allow this as long as some substitution of the *tuple[Any, ...] part would match the target type.
We could possibly also generalize the matching of unknown-length TypeVarTuple type arguments when the unknown-length part has a non-Any tuple item type. This could reduce apparent false positives. Example:
from typing import Any
class C[*Ts, S]:
pass
a = C[int, int]()
a = C[*tuple[int, ...]]() # No error?
This would only change the behavior of variadic generics. Variable-length tuples would continue to behave as they behave currently, i.e. tuple[int, ...] wouldn't be assignable to tuple[int, int]. The tuple behavior has been around for a very long time, so it doesn't make sense to change it, but variadic generics are a relatively new and untested feature.
The primary motivation is help with NumPy and libraries that provide multidimensional array-like types.
Proper subtype checks should continue to work as they work currently, since we can't safely simplify say C[int] | C[*tuple[Any, ...]].
cc @ilevkivskyi who I chatted about this recently
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza ejecutando con mypy los dos ejemplos de TypeVarTuple del issue y compara sus diagnósticos actuales. Investiga las rutas de compatibilidad de los variadic generics y de comprobación de subtipos, y después añade cobertura para los casos propuestos de longitud desconocida con Any y non-Any, preservando el comportamiento existente de las tuplas de longitud variable.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- devtools
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100