[regression] no type checking beyond perceived isinstance guard failure
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 20.6k
- Forks
- 3.3k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
Bug Report
Starting in mypy 1.5.0 (at least when testing in versions available in playground), there are situations where an isinstance type guard that returns False will cause type checking to stop in the false branch. The examples below check correctly in 1.4.1 in the playground.
To Reproduce
Heres a pretty dumb example
x: str
assert isinstance(x, int)
y: str = 1 # expected error here, got none
Another example:
from typing import Optional
class Foo:
x: Optional[str]
assert isinstance(Foo.x, int)
Foo.x.y.z = 1 # expected error here
These examples are lame, but there are legitimate use cases for this to work. For example, we use metaclasses to transform these type annotations on fields into class attributes that have underlying data. So a more real example in my use case (that cant be reproduced in a playground), would be:
class Foo(Model):
x: Optional[int] = field(max_length=1)
assert isinstance(Foo.x, StringField) # under the hood, we transform `Foo.x` into a `StringField` because of the annotation
assert Foo.x.max_lengt == 1 # expectd failures since max_lengt is a typo
Note that this behavior is mostly the same with if isinstance...: (and then the rest of the code within the block fails to check), though it seemed that some of those examples were also broken in 1.4.1, which is different than when using assert.
Expected Behavior
I would expect mypy to correctly type check even if it thinks an assert isinstance or if isinstance would result in the rest of the code being unreachable.
Note that I do not want to use warn-unreachable here because that would not actually solve the underlying problem, it would just give me extra warnings and still not actually let me write the isinstance checks that I want.
Actual Behavior
Mypy appears to give up type checking entirely - and silently - if it thinks that the rest of the code is unreachable.
Your Environment
My environment for all the examples is mypy playground
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Führe die Minimalbeispiele im mypy playground mit mypy 1.4.1 und 1.5.0 aus und vergleiche anschließend die assert- und if-Zweige. Verfolge den Type-Checking-Pfad für die Eingrenzung durch isinstance und nicht erreichbare Zweige. Als erledigt gilt die Aufgabe, wenn der false-Zweig weiterhin y: str = 1 und das falsch geschriebene Attribut meldet, ohne warn-unreachable zu erfordern.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- compilers
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100