mypy incorrectly complains about incompatible type error
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 20.6k
- Forks
- 3.3k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug Report
mypy is incorrectly complaining that the arguments to a function have an incompatible type, when used in the context of a class attribute.
In the example below, we are creating a library of fields (StringField, IntegerField, etc.), to be used in a runtime schema validation library. In addition, we create a OneOfField that takes a list of sub-fields via the with_ function. Creating a OneOfField works fine by itself, but when assigned to a class attribute, mypy incorrectly complains about a type error.
from typing import Generic, TypeVar, Union, assert_type, cast, overload, Self
InputType = TypeVar("InputType")
OutputType = TypeVar("OutputType")
class Field(Generic[InputType, OutputType]):
# We want both InputType and OutputType to be used in functions like the
# ones below, so they can't be marked covariant or contravariant.
def validate(self, input: Any) -> InputType:
return cast(InputType, input)
def render(self, input: InputType) -> OutputType:
return cast(OutputType, input)
def serialize(self, output: OutputType) -> str:
return ""
class StringField(Field[str, str]):
pass
class IntegerField(Field[int, int]):
pass
class BooleanField(Field[bool, bool]):
pass
def input_type(field: Field[InputType, OutputType]) -> InputType:
return cast(InputType, field)
OneOfInputType = TypeVar("OneOfInputType")
OneOfOutputType = TypeVar("OneOfOutputType")
AInputType = TypeVar("AInputType")
AOutputType = TypeVar("AOutputType")
BInputType = TypeVar("BInputType")
BOutputType = TypeVar("BOutputType")
CInputType = TypeVar("CInputType")
COutputType = TypeVar("COutputType")
class OneOfField(
Generic[OneOfInputType, OneOfOutputType],
Field[OneOfInputType, OneOfOutputType],
):
fields: list[Field]
def __init__(self) -> None:
super().__init__()
self.fields = []
@overload
def with_(
self,
a: Field[AInputType, AOutputType],
b: Field[BInputType, BOutputType],
) -> "OneOfField[Union[AInputType, BInputType], Union[AOutputType, BOutputType]]": ...
@overload
def with_(
self,
a: Field[AInputType, AOutputType],
b: Field[BInputType, BOutputType],
c: Field[CInputType, COutputType],
) -> "OneOfField[Union[AInputType, BInputType, CInputType], Union[AOutputType, BOutputType, COutputType]]": ...
def with_(
self,
a: Field[AInputType, AOutputType],
b: Field[BInputType, BOutputType],
c: Field[CInputType, COutputType] | None = None,
) -> "OneOfField":
if c is None:
self.fields = [a, b]
else:
self.fields = [a, b, c]
return self
def return_self(self) -> Self:
return self
# This works:
field = OneOfField().with_(StringField(), IntegerField())
assert_type(field, OneOfField[Union[str, int], Union[str, int]])
assert_type(input_type(field), Union[str, int])
# This doesn't work:
class MyModel:
# error: Argument 1 to "with_" of "OneOfField" has incompatible type "StringField"; expected "Field[str | int, str | int]" [arg-type]
# error: Argument 2 to "with_" of "OneOfField" has incompatible type "IntegerField"; expected "Field[str | int, str | int]" [arg-type]
foo: str | int = input_type(OneOfField().with_(StringField(), IntegerField()))
# This works?
class MyModel2:
foo: str | int = input_type(OneOfField().with_(StringField(), IntegerField()).return_self())
To Reproduce
https://gist.github.com/mypy-play/4619ce6d001d7c7c6994d2b6c912424a
This does not repro in Pyright: link
Expected Behavior
No errors.
Actual Behavior
mypy raises an invalid error saying the argument to with_ is invalid.
Your Environment
- Mypy version used: 1.13.0
- Mypy command-line flags: N/A
- Mypy configuration options from
mypy.ini(and other config files): N/A - Python version used: 3.13
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza ejecutando el ejemplo de Python del issue o su reproducción de mypy-play enlazada con mypy 1.13.0, centrándote en la expresión del atributo de clase y en la llamada encadenada a with_. Traza cómo se gestionan el tipado contextual y los métodos genéricos sobrecargados y, después, añade una prueba de regresión que muestre que la expresión no produce errores, conservando al mismo tiempo el comportamiento independiente existente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- devtools
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100