python / python/mypy

Overridden `__iter__` with more specific item type is only respected in some contexts

Abierto
#16,492 2 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug
Lenguaje dominante
Python
Estrellas
20.6k
Forks
3.3k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

Bug Report

Given a subclass C of Iterable[int] that more specifically implements def __iter__(self) -> Iterator[bool] (which is fine, since bool is a subclass of int), I would expect mypy to understand that iterating C() yields bools. And indeed it does understand this in some contexts, such as iter(C()) and for item in C(). But in other contexts, such as list(C()) and unpacking, it relies only on the base class Iterable[int] and discards the more specific information from __iter__.

To Reproduce

from typing import Iterable, Iterator

class C(Iterable[int]):
    def __iter__(self) -> Iterator[bool]:
        yield True

# these give bool, as expected
reveal_type(C().__iter__())  # Iterator[bool]
reveal_type(iter(C()))  # Iterator[bool]
reveal_type([comp_item for comp_item in C()])  # list[bool]
for loop_item in C(): reveal_type(loop_item)  # bool

# these unexpectedly give int
reveal_type(list(C()))  # list[int]
[unpack_item] = C(); reveal_type(unpack_item)  # int
[*unpack_items] = C(); reveal_type(unpack_items)  # list[int]

# these unexpectedly give Any
reveal_type([*C()])  # list[Any] (#15747)
reveal_type(max(*C()))  # Any

Playground link

Expected Behavior

All items should be inferred as bool.

main.py:8: note: Revealed type is "typing.Iterator[builtins.bool]"
main.py:9: note: Revealed type is "typing.Iterator[builtins.bool]"
main.py:10: note: Revealed type is "builtins.list[builtins.bool]"
main.py:11: note: Revealed type is "builtins.bool"
main.py:14: note: Revealed type is "builtins.list[builtins.bool]"
main.py:15: note: Revealed type is "builtins.bool"
main.py:16: note: Revealed type is "builtins.list[builtins.bool]"
main.py:19: note: Revealed type is "builtins.list[builtins.bool]"
main.py:20: note: Revealed type is "builtins.bool"

Actual Behavior

The items are inconsistently inferred as bool, int, or Any, depending on the context.

main.py:8: note: Revealed type is "typing.Iterator[builtins.bool]"
main.py:9: note: Revealed type is "typing.Iterator[builtins.bool]"
main.py:10: note: Revealed type is "builtins.list[builtins.bool]"
main.py:11: note: Revealed type is "builtins.bool"
main.py:14: note: Revealed type is "builtins.list[builtins.int]"
main.py:15: note: Revealed type is "builtins.int"
main.py:16: note: Revealed type is "builtins.list[builtins.int]"
main.py:19: note: Revealed type is "builtins.list[Any]"
main.py:20: note: Revealed type is "Any"

One of the Any cases was previously reported:

  • #14470
  • #15747

Your Environment

  • Mypy version used: 1.7.0
  • Mypy command-line flags: none
  • Mypy configuration options from mypy.ini (and other config files): none
  • Python version used: 3.11

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza ejecutando la reproducción del issue con mypy y compara los resultados de reveal_type para iter(C()), list(C()), el desempaquetado y los argumentos con asterisco. Rastrea los puntos de entrada de la comprobación de tipos para la construcción de listas, el desempaquetado y las llamadas con asterisco; se considera terminado cuando todos los tipos de elemento indicados se infieren sistemáticamente como bool, incluidos los casos Any notificados anteriormente.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
devtools
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.