Mypy runs really slow on a complicated, generator-heavy function
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 20.6k
- Forks
- 3.3k
- Merge medio
- 1 d 18 h
- PR fusionados (30 d)
- 54
Descripción
I have a function yield_programs, and it calls a helper function yield_actions. Obviously they are a bit complicated; they were written like this for fun. They live together in the following file:
import re
from itertools import product
from collections.abc import Iterator
SHIFTS = 'R', 'L'
HALT = '_'
def yield_actions(
states: int,
colors: int,
halt: bool = False,
) -> Iterator[str]:
yield from filter(
(
lambda action: action[2] != HALT or action == '1R_'
if halt
else lambda action: action
),
(
''.join(prod)
for prod in product(
tuple(map(str, range(colors))),
SHIFTS,
tuple(map(chr, range(65, 65 + states))) + ((HALT,) if halt else ()),
)
),
)
def yield_programs(
states: int,
colors: int,
halt: bool,
rejects: list[str] | None = None,
) -> Iterator[str]:
yield from filter(
lambda prog: not any(re.compile(regex).match(prog) for regex in rejects or []),
(
prog
for prog in (
' '.join(state)
for state in product(
(
' '.join(state)
for state in product(
yield_actions(states, colors, halt), repeat=colors # <-- call to yield_actions
)
),
repeat=states,
)
)
if (prog[:3] == '1RB' and (not halt or prog.count(HALT) == 1))
),
)
Mypy runs instantly and finds no issues.
Now I attempt to inline the call to yield_actions:
def yield_programs(
states: int,
colors: int,
halt: bool,
rejects: list[str] | None = None,
) -> Iterator[str]:
yield from filter(
lambda prog: not any(re.compile(regex).match(prog) for regex in rejects or []),
(
prog
for prog in (
' '.join(state)
for state in product(
(
' '.join(state)
for state in product(
filter( # <-- inlined call
(
lambda action: action[2] != HALT or action == '1R_'
if halt
else lambda action: action
),
(
''.join(prod)
for prod in product(
tuple(map(str, range(colors))),
SHIFTS,
tuple(map(chr, range(65, 65 + states)))
+ ((HALT,) if halt else ()),
)
),
),
repeat=colors,
)
),
repeat=states,
)
)
if (prog[:3] == '1RB' and (not halt or prog.count(HALT) == 1))
),
)
Mypy still finds no issues. However, it now takes around 50 seconds to run. Granted this function is bizarrely complicated (please don't ask why I would want to do such a thing), but that still seems like an awfully long time.
My feeling (which could be totally wrong) is that there is something that could be cached somewhere and that would fix this immediately. Or maybe it's because of the generators.
I did some profiling. Here is the callgraph colored by time spent in each function:

And the callgraph colored by time spent in each function along with subcalls:

mypy 0.982 (compiled: no)
Python 3.11.0
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Usa los ejemplos de yield_programs proporcionados para reproducir la diferencia entre llamar a yield_actions e insertar directamente su expresión de filtro. Perfila mypy mientras rastreas la comprobación de tipos alrededor de estos puntos de entrada y, después, compara las rutas de análisis relevantes. Se considera terminado cuando la forma insertada ya no provoca el retraso notificado sin cambiar los diagnósticos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- devtools, performance
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100