Mypy runs really slow on a complicated, generator-heavy function
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
I have a function yield_programs, and it calls a helper function yield_actions. Obviously they are a bit complicated; they were written like this for fun. They live together in the following file:
import re
from itertools import product
from collections.abc import Iterator
SHIFTS = 'R', 'L'
HALT = '_'
def yield_actions(
states: int,
colors: int,
halt: bool = False,
) -> Iterator[str]:
yield from filter(
(
lambda action: action[2] != HALT or action == '1R_'
if halt
else lambda action: action
),
(
''.join(prod)
for prod in product(
tuple(map(str, range(colors))),
SHIFTS,
tuple(map(chr, range(65, 65 + states))) + ((HALT,) if halt else ()),
)
),
)
def yield_programs(
states: int,
colors: int,
halt: bool,
rejects: list[str] | None = None,
) -> Iterator[str]:
yield from filter(
lambda prog: not any(re.compile(regex).match(prog) for regex in rejects or []),
(
prog
for prog in (
' '.join(state)
for state in product(
(
' '.join(state)
for state in product(
yield_actions(states, colors, halt), repeat=colors # <-- call to yield_actions
)
),
repeat=states,
)
)
if (prog[:3] == '1RB' and (not halt or prog.count(HALT) == 1))
),
)
Mypy runs instantly and finds no issues.
Now I attempt to inline the call to yield_actions:
def yield_programs(
states: int,
colors: int,
halt: bool,
rejects: list[str] | None = None,
) -> Iterator[str]:
yield from filter(
lambda prog: not any(re.compile(regex).match(prog) for regex in rejects or []),
(
prog
for prog in (
' '.join(state)
for state in product(
(
' '.join(state)
for state in product(
filter( # <-- inlined call
(
lambda action: action[2] != HALT or action == '1R_'
if halt
else lambda action: action
),
(
''.join(prod)
for prod in product(
tuple(map(str, range(colors))),
SHIFTS,
tuple(map(chr, range(65, 65 + states)))
+ ((HALT,) if halt else ()),
)
),
),
repeat=colors,
)
),
repeat=states,
)
)
if (prog[:3] == '1RB' and (not halt or prog.count(HALT) == 1))
),
)
Mypy still finds no issues. However, it now takes around 50 seconds to run. Granted this function is bizarrely complicated (please don't ask why I would want to do such a thing), but that still seems like an awfully long time.
My feeling (which could be totally wrong) is that there is something that could be cached somewhere and that would fix this immediately. Or maybe it's because of the generators.
I did some profiling. Here is the callgraph colored by time spent in each function:

And the callgraph colored by time spent in each function along with subcalls:

mypy 0.982 (compiled: no)
Python 3.11.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the supplied yield_programs examples to reproduce the contrast between calling yield_actions and inlining its filter expression. Profile mypy while tracing type checking around these entry points, then compare the relevant analysis paths. Done means the inline form no longer causes the reported delay without changing diagnostics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100