Changing just the return type annotation causes incompatible argument error
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 20.6k
- Forks
- 3.3k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
Bug Report
When a return type annotation changes from Iterable of Optional typevars into Iterable of Tuples of Optional typevars mypy starts to signal an error in function call arguments (invalid callback argument type).
To Reproduce
from typing import Callable, Iterable, Optional, Tuple, TypeVar
SourceType = TypeVar("SourceType")
TransformedType = TypeVar("TransformedType")
ProcessedType = TypeVar("ProcessedType")
def simple_transform_process(
source: Iterable[SourceType],
transform_callback: Callable[[SourceType], Optional[TransformedType]],
process_callback: Callable[[TransformedType], ProcessedType],
) -> Iterable[Optional[ProcessedType]]:
for item in source:
transformed = transform_callback(item)
if transformed is None:
yield None
else:
yield process_callback(transformed)
def transform_process(
source: Iterable[SourceType],
transform_callback: Callable[[SourceType], Optional[TransformedType]],
process_callback: Callable[[TransformedType], ProcessedType],
) -> Iterable[Tuple[Optional[TransformedType], Optional[ProcessedType]]]:
for item in source:
transformed = transform_callback(item)
if transformed is None:
yield None, None
else:
yield transformed, process_callback(transformed)
def transform(x: str) -> Optional[int]:
if x:
return int(x)
else:
return None
def process(x: int) -> float:
return x / 2
def test_simple_transform_process() -> None:
assert list(simple_transform_process(["", "2", "3"], transform, process)) == [
None,
1,
1.5,
]
def test_transform_process() -> None:
assert list(transform_process(["", "2", "3"], transform, process)) == [
(None, None),
(2, 1),
(3, 1.5),
]
(Write your steps here:)
- Run
mypyon the above codemypy test_mypy_problem.py
Expected Behavior
The code should have passed the type checker for both simple_transform_process call and transform_process call as both of those have the same exact signatures of input parameters.
Actual Behavior
mypy reports the following error on transform_process call:
test_mypy_problem.py:54: error: Argument 3 to "transform_process" has incompatible type "Callable[[int], float]"; expected "Callable[[Optional[int]], Optional[float]]"
The expected type of argument should be Callable[[int], float], just like for simple_transform_process and the code should pass the type checker.
Your Environment
- Mypy version used:
0.790,0.800,mypy 0.820+dev.dc4f0af163ed3748311115fd896494262c0dc644 - Mypy command-line flags:
mypy test_mypy_problem.py - Mypy configuration options from
mypy.ini(and other config files): no config file used - Python version used:
Python 3.8.5 - Operating system and version:
Ubuntu 20.04.2 LTS
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit dem Reproduzierer in test_mypy_problem.py und führe mypy test_mypy_problem.py mit den angegebenen Python- und mypy-Versionen aus. Verfolge, wie die generische Inferenz den transform_process-Callback im Vergleich zu simple_transform_process behandelt, und füge anschließend einen Regressionstest hinzu, der zeigt, dass beide Aufrufe erfolgreich typgeprüft werden.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- compilers
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 48/100