python / python/cpython

__get__ called without being bound when a bound method should be called

未關閉
#98,905 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

interpreter-core
主要語言
Python
星號
77.2k
分支
36k
PR 合併指標
PR 指標待擷取

描述

(Edited a not important part of the code.)

Suppose a class D has a __get__ method D.__dict__["__get__"] for its instances, and O.__dict__["d"] is an object of type D, where O is a class. Then, for an object o of type O, my expectation was the value o.d would be got as (O.__dict__["d"]).__get__(o, O). In reality, its evaluation tries to call D.__dict__["__get__"] (on the arguments O.__dict__["d"], o, O). See the code below. I used Python 3.9.7 on MacOS.

This means it wouldn't help if d.__get__ will be callable for every object d of type D. For instance, D.__dict__["__get__"] can't be of type property, functools.partialmethod or staticmethod to work properly. Another concern is if D.__dict__["__get__"] happens to be callable in an unexpected way, then one can get an unexpected value for o.d, which would be worse if it happens. (If D.__dict__["__get__"] is callable and its class type(D.__dict__["__get__"]) doesn't have or inherit a __get__ method, then that __get__ method of D seems to be meant static.)

I don't know where else a dunder method may be required to be callable without being bound, but I think such a requirement should be replaced with one that bound methods be callable. In the case above, evaluation of o.d (or O.d) should call the bound method (O.__dict__["d"]).__get__.

Here's a code for your convenience.

from functools import partial

# Utility
def unpack(iterator):
    next_ = iterator.__next__
    while True:
        try:
            next_()
        except StopIteration:
            return

# Context
class Get:
    '''Creates a method to be __get__ .
    '''
    def __get__(self, descriptor, owner=None):
        return self if descriptor is None\
            else partial(self._do, descriptor)

    def _do(self, descriptor, instance, owner=None):
        return descriptor if instance is None else None

    # For the purpose of inspection, instances will be callable in an
    # unexpected way.
    def __call__(self, /, *args, **kwargs):
        print("Called:", (dict_ := locals()).pop("self"))
        return dict_

class D:
    '''A class of descriptors.
    '''
    __get__ = Get()

    def __set__(self, instance, value):
        return

    def __delete__(self, instance):
        return

class O:
    '''A class with a descriptor of type D .
    '''
    d = D()

# Test
unpack(map(print,
           map(eval,
               map("f'{{{}=}}'".format,
                   ('D.__dict__["__get__"]',
                    'O.__dict__["d"]',
                    'O.d',
                    '(o := O())',
                    'o.d', )))))

The expectation from the code is

O.d ---> O.__dict__["d"],
o.d ---> None.

An example of what actually get printed:

D.__dict__["__get__"]=<__main__.Get object at 0x100e21400>
O.__dict__["d"]=<__main__.D object at 0x100e213d0>
Called: <__main__.Get object at 0x100e21400>
O.d={'args': (<__main__.D object at 0x100e213d0>, None, <class '__main__.O'>), 'kwargs': {}}
(o := O())=<__main__.O object at 0x100e210a0>
Called: <__main__.Get object at 0x100e21400>
o.d={'args': (<__main__.D object at 0x100e213d0>, <__main__.O object at 0x100e210a0>, <class '__main__.O'>), 'kwargs': {}}

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

首先執行 issue 中的 reproducer,並追蹤 O.d 和 o.d 的 descriptor 查找,著重了解 get 如何被呼叫。符合以下預期行為即表示完成:O.d 回傳 O.dict["d"],而 o.d 回傳 None,並為該範例加入回歸測試涵蓋。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
compilers
Issue 類型
缺陷
難度
5/5
預估耗時
一週以上
活躍度
停滯
描述清晰度
基本清楚
新手友好度
25/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。