PRECALL and CALL description in dis module is misleading
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
Documentation
PRECALL is presented as an effective NOP in the documentation however it has a non-zero stack_effect, which means it does alter the stack. Furthermore CALL handling of the argument is not accurate since the stack_effect of CALL is -1 and is independent from the argument value.
As a consequence, the relation between CALL and PRECALL deserves to be clarified IMO.
@iritkatriel you might be interested in the issue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the PRECALL and CALL entries in the dis module documentation and compare their descriptions with the stated stack effects. Done means the documentation accurately explains PRECALL's stack behavior and how CALL's argument handling relates to PRECALL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100