os.path.ismounts: further situations it doesn't detect correctly
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 36k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug report
I had a look at os.path.ismount():
https://github.com/python/cpython/blob/43a6deadbb40bc93e0eaebb3c56c34f8a3502132/Lib/posixpath.py#L186-L216
And it may have some issues:
- The documentation already says, that it isn't capable of detecting bind-mounts of some filesystem on the very same filesystem. While it's good that it mentions this, the results of
ismount()is IMO still simply wrong in these cases, cause it is a mountpoint. - The same problem in the detection algorithm is not only limited to bind-mounts, but also to any other mount points, where the path’s
st_devequals that of its parent. For example, btrfs subvolumes. This is however not documented.
Looking a the code, it effectively does: lstat(), check whether it’s a symlink, lstat() the parent, check whether the device numbers are different (then it's a mountpoint), check whether the inodes are the same.
Now I thought about the latter, and what it is meant for.
The only case I could think of at first is /, where /.. is the same inode. [Is there any other?]
- This however already requires, that not only the inodes are the same, but also the device numbers. which is given because of the order of these checks, however, I'd suggest to comment that accordingly.
- If the above were the only case, wouldn't it be faster to simply check the pathname for being
"/"orb"/". Would perhaps require somerealpath()though, to also catch things like"/../.."and so on. - However, I found that
/is not the only case: Within a chroot, the chroot's/may (or may not) be a mountpoint - the problem is just, the current algorithm doesn't detect this either. Instead, it wrongly claims that a chroot’s "/" would be a mountpoint, even when it isn't.
Not sure what one could do about all that… /etc/mtab is dead... /proc/mounts may not be available on all POSIX systems and even on Linux it's nowadays rather superseded by /proc/self/mountinfo.
Your environment
- CPython versions tested on: 3.10.6
- Operating system and architecture: Debian sid
Cheers,
Chris.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con os.path.ismount() en Lib/posixpath.py, especialmente con la implementación enlazada, y revisa su documentación. Reproduce los casos indicados de bind-mount, subvolumen de btrfs y chroot en el entorno Debian especificado. El trabajo se considerará terminado cuando haya un enfoque de detección acordado, un comportamiento corregido y documentación de las limitaciones de plataforma restantes.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- operating-systems
- Tipo de issue
- Error
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 30/100