python / python/cpython

IDLE: Move unittests to test directory

未关闭
#95,069 3 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@terryjreedy 已经在做这个了。

开始于 2022年7月20日。

tests topic-IDLE type-feature
主要语言
Python
星标
77.2k
派生
36k
PR 合并指标
PR 指标待抓取

描述

In particular, move unittest-related files in idlelib.idle_test to a new test/test_idle directory and split test/test_idle.py into test_idle/__init__.py and test_idle/__main__.py. This is a followup to #54781 and similar issues before and after. Note that I want idle_test and any non-unittest files (at least htest.py and part of README.txt) left as they are.

Other core developers want this for consistency, as best explained by Victor Stinner in https://github.com/python/cpython/issues/93839#issue-1271983348. None of those benefits apply to me, and there are costs to the change that could or would make IDLE development harder, perhaps significantly so.

The costs come from some of idlelib's special features as a package: a) it comprises about 60 modules, far more than any other stdlib package; b) the test suite is underdeveloped relative to at least some other packages, so there are (or should be) relatively more future test changes to be impacted; c) PEP 434 allows name changes and backports not allowed elsewhere in the stdlib, so there are many more of these.

  1. Search and replacement: a multifile recursive search currently displays all hits in idlelib and idlelib.idle_test with one command and puts all hits in one window. When editing any idlelib file, Alt-F3 opens IDLE's grep with idlelib as the default search directory. Having to give the command twice and having the results in two windows would be a pain. (IDLE's grep could special case recursive searches in idlelib to include test.test_idle.)

  2. Existing PRs: I would guess that there are at least 20 current PRs that modify IDLE tests. Will they all break or will old paths be automatically mapped to new paths. If they will break, I would want an automated fix (for just main) or else dispose of most of them before moving the tests.

  3. Backports: currently, code backports, which are nearly always done, are accompanied by any corresponding test changes. Victor claims in #94145 that git will always (my emphasis) map new paths in a PR to the old paths. (This would require that it keep a reverse dictionary of path changes.) I would like to see this work before I believe this.

Linked PRs
  • gh-115444

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。