Comment for bounded_lru_cache_wrapper seems incorrect
Aperta
@tim-one ci sta già lavorando.
Dal 17/7/2022.
extension-modules
type-bug
- Lingua principale
- Python
- Stelle
- 77.2k
- Fork
- 36k
- Metriche di merge delle PR
- Metriche PR in attesa
Descrizione
https://github.com/python/cpython/blob/c22f134211743cd5ad14cec1dd4f527bee542b4c/Modules/_functoolsmodule.c#L975-L976
However the __eq__ method call actually could be made for the deletion of the oldest entry.
from functools import lru_cache
class A:
def __init__(self, name):
self.name = name
self.counter = []
def __hash__(self):
return 0 # mock hash collision
def __eq__(self, __o: 'A'):
self.counter.append(__o.name)
return self is __o
@lru_cache(maxsize=2)
def foo(_):
return 0
a, b, c = A('a'), A('b'), A('c')
foo(a)
foo(b)
# make 'b' be the oldest-used entry
# but not the oldest-inserted entry
foo(a)
a.counter.clear()
foo(c) # will evict 'b'
# The assertion shows that
# 'a' was compared with 'b' for the deletion of 'b'
assert 'b' in a.counter
print(a.counter) # ['c', 'c', 'b', 'c']
It seems that reentrant here might cause the assertion in L1092 failed:
https://github.com/python/cpython/blob/c22f134211743cd5ad14cec1dd4f527bee542b4c/Modules/_functoolsmodule.c#L1092-L1099
Since link has been extracted but hasn't been popped from cache dict, link list could be empty while cache dict is full.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.