Inconsistency in handling None handlers in the Python and C implementations of pickle
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 36k
- PR 合并指标
- PR 指标待抓取
描述
In the Python implementation of pickle setting some handlers to None causes a fallback to other methods.
- Setting
Pickler.reducer_overrideto None has the same effect as not setting this attribute -- falling back to other methods. - Setting the
dispatch_tableto None leads to falling back to__reduce_ex__. - Setting the
__reduce_ex__attribute to None leads to falling back to__reduce__. - Setting the
__setstate__attribute to None leads to falling back to the default implementation of__setstate__(setting__dict__and slots).
In the C implementation all this leads to TypeError: 'NoneType' object is not callable.
The copy module follows the Python implementation of pickle, except that it fails for any false value of __reduce__, not just None.
In most other code setting a dunder method to None leads to a TypeError (either raise explicitly or just generic "'NoneType' object is not callable").
We should decide what behavior should be in the pickle and copy module. On one hand, the Python implementation was primary. On other hand, it was inconsistent between the pickle and copy modules and was already changed in the past, the C implementation of pickle is now used by most users, and it is more consistent with other code.
See also:
https://mail.python.org/archives/list/python-dev@python.org/thread/YGAK34DRWJFSIV2VZ4NC2J24XO37GCMM/
https://docs.python.org/3.10/reference/datamodel.html#id2
https://github.com/python/cpython/issues/70146
https://github.com/python/cpython/issues/55781
https://github.com/python/cpython/issues/60755
Linked PRs
- gh-103035
- gh-109498
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先阅读 pickle 和 copy 模块的 Python 与 C 实现,然后审阅关联的 pull request gh-103035 和 gh-109498。完成这项工作需要就 None 处理程序的行为达成一致,并确保受影响的各个实现之间的处理方式一致。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, python
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 25/100