Don't run importlib tests for the "source" version
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 36k
- PR 合并指标
- PR 指标待抓取
描述
Feature or enhancement
Simplify the test suite by not running the importlib tests on the source version, only the frozen one.
Pitch
Currently, we are running the tests against both the source and frozen versions of importlib.
Example:
https://github.com/python/cpython/blob/main/Lib/test/test_importlib/test_api.py#L97-L99
In #92265, we ran into a non-trivial issue where the frozen finders were leaking into source version of the tests, and I suspect some other tests might have the same issue. Me and @ericsnowcurrently spent quite a bit of time tracking it down, though I acknowledge it could have been easier for someone like Brett, who is more versed in this part of the code.
AFAICT, the only version of the modules users will actually use is the frozen one, making me question if the increased complexity in the test suite is worth it. I am under the impression that this was not always the case, which would explain a bit better why we are testing both versions.
So, would it be reasonable to simply remove the source version of the tests? What value is it actually providing? Did I overlook something here?
cc @brettcannon @ericsnowcurrently @warsaw
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Lib/test/test_importlib/test_api.py 中约第 97-99 行的 importlib 测试设置开始,然后检查 source 和 frozen 测试路径,以及 #92265 中描述的问题。确定 source 版本测试提供了哪些覆盖;完成的标准是记录理由,并且仅在该覆盖没有必要时修改测试套件。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- testing-qa
- Issue 类型
- 重构
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100