python / python/cpython

Library json, file json/encoder.py: Function floatstr should be a class-level function.

Open
#86,600 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.10 3.7 (EOL) 3.8 (EOL) 3.9 (EOL) stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 42434
PRs
  • python/cpython#23459
  • Files
  • encoder.py: Code of file cpython/Lib/json/encoder.py with strange behaviour
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-11-22.11:15:21.561>
    labels = ['3.7', '3.8', '3.9', '3.10', 'type-feature', 'library']
    title = 'Library json, file json/encoder.py: Function floatstr should be a class-level function.'
    updated_at = <Date 2020-11-22.11:20:47.761>
    user = 'https://bugs.python.org/salacdav'
    

    bugs.python.org fields:

    activity = <Date 2020-11-22.11:20:47.761>
    actor = 'python-dev'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-11-22.11:15:21.561>
    creator = 'salacdav'
    dependencies = []
    files = ['49613']
    hgrepos = []
    issue_num = 42434
    keywords = ['patch']
    message_count = 1.0
    messages = ['381609']
    nosy_count = 2.0
    nosy_names = ['python-dev', 'salacdav']
    pr_nums = ['23459']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue42434'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with json/encoder.py and review the linked pull request python/cpython#23459 to understand the proposed class-level treatment of floatstr. Confirm the intended behavior against the issue's description and existing implementation, then ensure the change is covered by the relevant JSON encoder tests before considering it done.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Feature
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.