python / python/cpython

add support for os.PathLike filename in zipfile.ZipFile.write()

Open
#84,686 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 40506
Nosy @Yhg1s, @ethanfurman, @serhiy-storchaka, @domragusa
Files
  • pathlike_writestr.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-05-05.02:12:03.387>
    labels = ['type-feature', 'library', '3.10']
    title = 'add support for os.Pathlike filenames in zipfile.ZipFile.writestr'
    updated_at = <Date 2021-09-08.00:49:22.380>
    user = 'https://github.com/domragusa'
    

    bugs.python.org fields:

    activity = <Date 2021-09-08.00:49:22.380>
    actor = 'ethan.furman'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-05-05.02:12:03.387>
    creator = 'd.ragusa'
    dependencies = []
    files = ['49132']
    hgrepos = []
    issue_num = 40506
    keywords = ['patch']
    message_count = 2.0
    messages = ['368098', '368289']
    nosy_count = 4.0
    nosy_names = ['twouters', 'ethan.furman', 'serhiy.storchaka', 'd.ragusa']
    pr_nums = ['20002']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue40506'
    versions = ['Python 3.10']
    

    Linked PRs
    • gh-20002
    • gh-113386

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the zipfile.ZipFile.write() entry point and review the linked pathlike_writestr.patch, along with PRs gh-20002 and gh-113386. Done means support for os.PathLike filenames in this method is covered and the existing work has been resolved.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Feature
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    30/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.