python / python/cpython

Never return base's fragment from urljoin (urllib.parse)

Open
#83,980 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.9 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 39799
Nosy @openandclose
PRs
  • python/cpython#18710
  • Files
  • 1.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-02-29.15:04:08.115>
    labels = ['type-bug', 'library', '3.9']
    title = "Never return base's fragment from urljoin (urllib.parse)"
    updated_at = <Date 2020-02-29.20:02:49.256>
    user = 'https://github.com/openandclose'
    

    bugs.python.org fields:

    activity = <Date 2020-02-29.20:02:49.256>
    actor = 'op368'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-02-29.15:04:08.115>
    creator = 'op368'
    dependencies = []
    files = ['48935']
    hgrepos = []
    issue_num = 39799
    keywords = ['patch']
    message_count = 2.0
    messages = ['362983', '362984']
    nosy_count = 1.0
    nosy_names = ['op368']
    pr_nums = ['18710']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue39799'
    versions = ['Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    The issue concerns urllib.parse.urljoin and links to PR #18710 and patch 1.patch. Start by reviewing the current urljoin behavior alongside the linked patch; done means the base URL's fragment is never returned in the affected cases.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.