python / python/cpython

modulefinder should use import hooks properly

Open
#82,902 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.9 (EOL) stdlib topic-importlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

BPO 38721
Nosy @brandtbucher, @plokmijnuhby
PRs
  • python/cpython#17326
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-11-06.16:05:22.294>
    labels = ['type-feature', 'library', '3.9']
    title = 'modulefinder should use import hooks properly'
    updated_at = <Date 2019-11-22.23:37:04.831>
    user = 'https://github.com/plokmijnuhby'
    

    bugs.python.org fields:

    activity = <Date 2019-11-22.23:37:04.831>
    actor = 'plokmijnuhby'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-11-06.16:05:22.294>
    creator = 'plokmijnuhby'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38721
    keywords = ['patch']
    message_count = 8.0
    messages = ['356143', '356547', '356746', '356908', '357215', '357216', '357219', '357340']
    nosy_count = 2.0
    nosy_names = ['brandtbucher', 'plokmijnuhby']
    pr_nums = ['17326']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue38721'
    versions = ['Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reviewing PR python/cpython#17326 and the modulefinder library implementation. Use the issue title and the existing patch as the scope; done means modulefinder uses import hooks properly and the relevant behavior is covered by the proposed change.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    tooling
    Issue type
    Feature
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    15/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.