python / python/cpython

simplify overlaps function in ipaddress.py

未关闭
#82,516 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

stdlib type-feature
主要语言
Python
星标
77.2k
派生
36k
PR 合并指标
PR 指标待抓取

描述

BPO 38335
Nosy @serhiy-storchaka, @s-sanjay
PRs
  • python/cpython#16519
  • Files
  • skip_broadcast_in.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-10-01.11:43:43.734>
    labels = ['3.8', '3.7', 'library', '3.9']
    title = 'simplify overlaps function in ipaddress.py'
    updated_at = <Date 2019-10-05.12:25:55.200>
    user = 'https://github.com/s-sanjay'
    

    bugs.python.org fields:

    activity = <Date 2019-10-05.12:25:55.200>
    actor = 'Sanjay'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-10-01.11:43:43.734>
    creator = 'Sanjay'
    dependencies = []
    files = ['48634']
    hgrepos = []
    issue_num = 38335
    keywords = ['patch']
    message_count = 3.0
    messages = ['353676', '354004', '354005']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'Sanjay']
    pr_nums = ['16519']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue38335'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    

    贡献指南

    打开贡献指南

    从这里开始

    1. 先读完整个 Issue,再读项目的贡献指南。
    2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
    3. Fork 仓库,在一个分支上完成修改。
    4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

    调研方向

    从 ipaddress.py 中的 overlaps 函数开始,检查所引用的 skip_broadcast_in.patch 和 PR 16519。根据现有行为确认预期的简化方式,然后运行相关的 ipaddress 测试;完成的标准是函数得到简化且结果不变。

    由索引模型根据 Issue 内容生成。

    评估

    技术栈
    python
    领域
    networking
    Issue 类型
    重构
    难度
    2/5
    预计耗时
    1-3 小时
    活跃度
    停滞
    描述清晰度
    基本清楚
    新手友好度
    25/100

    把新 issue 发到你的邮箱

    精选适合新手参与的 GitHub issue 摘要。