python / python/cpython

simplify overlaps function in ipaddress.py

Open
#82,516 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 38335
Nosy @serhiy-storchaka, @s-sanjay
PRs
  • python/cpython#16519
  • Files
  • skip_broadcast_in.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-10-01.11:43:43.734>
    labels = ['3.8', '3.7', 'library', '3.9']
    title = 'simplify overlaps function in ipaddress.py'
    updated_at = <Date 2019-10-05.12:25:55.200>
    user = 'https://github.com/s-sanjay'
    

    bugs.python.org fields:

    activity = <Date 2019-10-05.12:25:55.200>
    actor = 'Sanjay'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-10-01.11:43:43.734>
    creator = 'Sanjay'
    dependencies = []
    files = ['48634']
    hgrepos = []
    issue_num = 38335
    keywords = ['patch']
    message_count = 3.0
    messages = ['353676', '354004', '354005']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'Sanjay']
    pr_nums = ['16519']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue38335'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with the overlaps function in ipaddress.py and review the referenced skip_broadcast_in.patch and PR 16519. Confirm the intended simplification against the existing behavior, then run the relevant ipaddress tests; done means the function is simplified without changing its results.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    networking
    Issue type
    Refactor
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.