Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)
Open
Nobody has claimed this yet.
3.9 (EOL)
interpreter-core
type-feature
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
| BPO | 37812 |
|---|---|
| Nosy | @tim-one, @rhettinger, @mdickinson, @vstinner, @animalize, @gnprice, @sir-sigurd, @aeros |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2019-08-10.21:07:30.736>
labels = ['interpreter-core', 'type-feature', '3.9']
title = 'Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)'
updated_at = <Date 2019-09-22.06:41:33.865>
user = 'https://github.com/gnprice'
bugs.python.org fields:
activity = <Date 2019-09-22.06:41:33.865>
actor = 'aeros'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2019-08-10.21:07:30.736>
creator = 'Greg Price'
dependencies = []
files = []
hgrepos = []
issue_num = 37812
keywords = ['patch']
message_count = 36.0
messages = ['349359', '349360', '349376', '349377', '349379', '349414', '349418', '349420', '349425', '349429', '349430', '350352', '350353', '350378', '350380', '350398', '350402', '352670', '352685', '352688', '352689', '352690', '352691', '352693', '352694', '352695', '352709', '352781', '352833', '352834', '352836', '352837', '352838', '352842', '352904', '352963']
nosy_count = 8.0
nosy_names = ['tim.peters', 'rhettinger', 'mark.dickinson', 'vstinner', 'malin', 'Greg Price', 'sir-sigurd', 'aeros']
pr_nums = ['15203', '15216', '15448']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37812'
versions = ['Python 3.9']
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in longobject.c at the CHECK_SMALL_INT macro and review the issue-linked PRs 15203, 15216, and 15448 before making changes. Confirm which implicit returns remain in scope, then run the relevant CPython interpreter tests and verify that the returns are explicit without changing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100