python / python/cpython

mock uses incorrect signature for partial and partialmethod with autospec

Open
#79,644 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) 3.8 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 35463
Nosy @cjw296, @voidspace, @mariocj89, @pablogsal, @tirkarthi

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-12-11.14:47:32.441>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'mock uses incorrect signature for partial and partialmethod with autospec'
updated_at = <Date 2018-12-11.14:47:32.441>
user = 'https://github.com/tirkarthi'

bugs.python.org fields:

activity = <Date 2018-12-11.14:47:32.441>
actor = 'xtreak'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2018-12-11.14:47:32.441>
creator = 'xtreak'
dependencies = []
files = []
hgrepos = []
issue_num = 35463
keywords = []
message_count = 1.0
messages = ['331631']
nosy_count = 5.0
nosy_names = ['cjw296', 'michael.foord', 'mariocj89', 'pablogsal', 'xtreak']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35463'
versions = ['Python 3.7', 'Python 3.8']

Linked PRs
  • gh-153580

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing Python's mock handling for partial, partialmethod, and autospec, then inspect the existing tests around their signatures. Compare the current behavior with the issue's reported incorrect signature and use the linked PR gh-153580 as context; done means the autospec signature behavior is corrected and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.