python / python/cpython

pty.py: pty.spawn hangs after client disconnect over nc (netcat)

Open
#73,240 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) stdlib type-feature
Dominant language
Python
Stars
77.2k
Forks
36k
Avg merge
1d 9h
Merged PRs (30d)
558

Description

BPO 29054
Nosy @vstinner, @vadmium, @diekmann
Files
  • pty.patch: Hacky patch with placeholder
  • pty.patch: Patch with test cases. If the tests are not red on other obscure UNIXes, consider merging.
  • pty.patch: Same, but without git patch header
  • pty.patch: Same, but without git patch header. Why does the review tool not show test_pty.py?
  • pty_and_tests.patch: Same, but less broken diff format.
  • test_pty_and_doc.patch: Document and test existing behavior, no change in behavior.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-12-23.14:17:17.681>
    labels = ['3.7', 'type-feature', 'library']
    title = 'pty.py: pty.spawn hangs after client disconnect over nc (netcat)'
    updated_at = <Date 2017-01-06.12:37:37.535>
    user = 'https://github.com/diekmann'
    

    bugs.python.org fields:

    activity = <Date 2017-01-06.12:37:37.535>
    actor = 'Cornelius Diekmann'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2016-12-23.14:17:17.681>
    creator = 'Cornelius Diekmann'
    dependencies = []
    files = ['46006', '46010', '46012', '46013', '46015', '46023']
    hgrepos = []
    issue_num = 29054
    keywords = ['patch']
    message_count = 9.0
    messages = ['283880', '283899', '283904', '283905', '283909', '283912', '283952', '284494', '284816']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'martin.panter', 'Cornelius Diekmann']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29054'
    versions = ['Python 3.7']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start with pty.py and the test_pty.py coverage referenced in the uploaded patches; reproduce the pty.spawn hang after the netcat client disconnects. Review the existing pty.patch and test_pty_and_doc.patch, then confirm that the test cases pass without regressing behavior on supported Unix systems.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    operating-systems
    Issue type
    Bug
    Difficulty
    4/5
    Estimated time
    3-5 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.