python / python/cpython

NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

未关闭
#73,053 12 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

3.7 (EOL) stdlib type-bug
主要语言
Python
星标
77.2k
派生
36k
PR 合并指标
PR 指标待抓取

描述

BPO 28867
Nosy @vstinner, @bitdancer, @jdufresne
PRs
  • python/cpython#1936
  • Files
  • namedtemporaryfile-resourcewarning.patch: Patch to add ResourceWarning to NamedTemporaryFile
  • namedtemporaryfile-resourcewarning-2.patch: Updated patch
  • namedtemporaryfile-resourcewarning-3.patch: Patch take 3
  • namedtemporaryfile-resourcewarning-4.patch: Patch take 4
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-12-04.17:47:27.371>
    labels = ['3.7', 'type-bug', 'library']
    title = 'NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)'
    updated_at = <Date 2017-06-04.03:13:36.750>
    user = 'https://github.com/jdufresne'
    

    bugs.python.org fields:

    activity = <Date 2017-06-04.03:13:36.750>
    actor = 'jdufresne'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2016-12-04.17:47:27.371>
    creator = 'jdufresne'
    dependencies = []
    files = ['45783', '45789', '45851', '45852']
    hgrepos = []
    issue_num = 28867
    keywords = ['patch']
    message_count = 11.0
    messages = ['282352', '282355', '282360', '282366', '282372', '282599', '282629', '282630', '282631', '282933', '282955']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'r.david.murray', 'SilentGhost', 'jdufresne']
    pr_nums = ['1936']
    priority = 'normal'
    resolution = None
    stage = 'needs patch'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue28867'
    versions = ['Python 3.6', 'Python 3.7']
    

    贡献指南

    打开贡献指南

    从这里开始

    1. 先读完整个 Issue,再读项目的贡献指南。
    2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
    3. Fork 仓库,在一个分支上完成修改。
    4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

    调研方向

    首先查看 issue 中链接的 namedtemporaryfile-resourcewarning.patch 文件,以及它们所涉及的 NamedTemporaryFile 和 TemporaryFile 入口点。验证未关闭的 NamedTemporaryFile 相对于 TemporaryFile 的 ResourceWarning 行为,确保更新后的补丁及其测试展示预期结果。

    由索引模型根据 Issue 内容生成。

    评估

    技术栈
    python
    领域
    backend
    Issue 类型
    缺陷
    难度
    3/5
    预计耗时
    1-2 天
    活跃度
    停滞
    描述清晰度
    基本清楚
    新手友好度
    25/100

    把新 issue 发到你的邮箱

    精选适合新手参与的 GitHub issue 摘要。