python / python/cpython

NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

Open
#73,053 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 28867
Nosy @vstinner, @bitdancer, @jdufresne
PRs
  • python/cpython#1936
  • Files
  • namedtemporaryfile-resourcewarning.patch: Patch to add ResourceWarning to NamedTemporaryFile
  • namedtemporaryfile-resourcewarning-2.patch: Updated patch
  • namedtemporaryfile-resourcewarning-3.patch: Patch take 3
  • namedtemporaryfile-resourcewarning-4.patch: Patch take 4
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-12-04.17:47:27.371>
    labels = ['3.7', 'type-bug', 'library']
    title = 'NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)'
    updated_at = <Date 2017-06-04.03:13:36.750>
    user = 'https://github.com/jdufresne'
    

    bugs.python.org fields:

    activity = <Date 2017-06-04.03:13:36.750>
    actor = 'jdufresne'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2016-12-04.17:47:27.371>
    creator = 'jdufresne'
    dependencies = []
    files = ['45783', '45789', '45851', '45852']
    hgrepos = []
    issue_num = 28867
    keywords = ['patch']
    message_count = 11.0
    messages = ['282352', '282355', '282360', '282366', '282372', '282599', '282629', '282630', '282631', '282933', '282955']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'r.david.murray', 'SilentGhost', 'jdufresne']
    pr_nums = ['1936']
    priority = 'normal'
    resolution = None
    stage = 'needs patch'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue28867'
    versions = ['Python 3.6', 'Python 3.7']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reviewing the namedtemporaryfile-resourcewarning.patch files linked in the issue and the NamedTemporaryFile and TemporaryFile entry points they address. Verify the ResourceWarning behavior for an unclosed NamedTemporaryFile against TemporaryFile, with the updated patch and its tests showing the intended result.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    backend
    Issue type
    Bug
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    25/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.