python / python/cpython

mock.patch decorating a generator returns a regular function.

Open
#71,528 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 27341
Nosy @terryjreedy, @rbtcollins, @voidspace, @shoshber, @tirkarthi
Files
  • silentfail.py: example tests
  • actual.out: output
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-06-17.05:35:08.841>
    labels = ['type-bug', 'tests']
    title = 'mock.patch decorating a generator returns a regular function.'
    updated_at = <Date 2019-12-13.11:13:51.134>
    user = 'https://github.com/shoshber'
    

    bugs.python.org fields:

    activity = <Date 2019-12-13.11:13:51.134>
    actor = 'xtreak'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2016-06-17.05:35:08.841>
    creator = 'shoshber'
    dependencies = []
    files = ['43443', '43444']
    hgrepos = []
    issue_num = 27341
    keywords = []
    message_count = 6.0
    messages = ['268709', '268749', '268757', '268758', '268761', '268762']
    nosy_count = 5.0
    nosy_names = ['terry.reedy', 'rbcollins', 'michael.foord', 'shoshber', 'xtreak']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'test needed'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue27341'
    versions = ['Python 3.5', 'Python 3.6']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    The issue links silentfail.py as example tests and actual.out as recorded output. Start by running the example and comparing its generator behavior with the output, then trace the mock.patch implementation and existing mock tests. Done means a regression test captures the decorator behavior and the test suite passes.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    testing-qa
    Issue type
    Bug
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Needs clarification
    Newbie friendliness
    35/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.