python / python/cpython

Unexpected call to readline's add_history in call_readline

Open
#71,057 18 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

extension-modules type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 26870
Nosy @Yhg1s, @meadori, @vadmium, @tylercrompton
Files
  • readline_history.py: script that demonstrates the described behavior
  • set_auto_history.patch: Patch to implement new function in readline module
  • test_set_auto_history.py: Test script for new function in readline module
  • set_auto_history.v2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-04-27.07:52:14.793>
    labels = ['extension-modules', 'type-bug']
    title = "Unexpected call to readline's add_history in call_readline"
    updated_at = <Date 2016-05-15.16:01:48.548>
    user = 'https://github.com/tylercrompton'
    

    bugs.python.org fields:

    activity = <Date 2016-05-15.16:01:48.548>
    actor = 'martin.panter'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2016-04-27.07:52:14.793>
    creator = 'tylercrompton'
    dependencies = []
    files = ['42626', '42748', '42749', '42788']
    hgrepos = []
    issue_num = 26870
    keywords = ['patch']
    message_count = 18.0
    messages = ['264360', '264370', '264378', '264955', '265119', '265184', '265192', '265497', '265567', '265570', '265571', '265572', '265574', '265575', '265604', '265614', '265618', '265626']
    nosy_count = 5.0
    nosy_names = ['twouters', 'meador.inge', 'python-dev', 'martin.panter', 'tylercrompton']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'needs patch'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue26870'
    versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start by reproducing the behavior with readline_history.py, then inspect the readline module entry point and compare the proposed set_auto_history.patch with set_auto_history.v2.patch. Use test_set_auto_history.py to understand the intended behavior; done means the unexpected add_history call is addressed and the test verifies it.

    Written by the indexing model from the issue text.

    Assessment

    Tech stack
    python
    Domain
    cli
    Issue type
    Bug
    Difficulty
    3/5
    Estimated time
    1-2 days
    Activity status
    Stale
    Clarity
    Mostly clear
    Newbie friendliness
    35/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.