shlex lineno inaccurate with certain inputs

Open
#69,057 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start by reading the shlex implementation alongside the reported examples in badlex.py and ambigious_shlex.py, then review issue24869.patch. Reproduce the inaccurate line numbers and compare them with the expected token stream; done means the examples report correct lineno values with appropriate regression coverage.

Written by the indexing model from the issue text.

Description

stdlib type-bug
BPO 24869
Nosy @vsajip, @akheron, @gareth-rees, @hoadlck
PRs
  • python/cpython#2799
    		•
    Files
  • badlex.py: Example of described behavior.
  • ambigious_shlex.py: Example of ambigious token stream
  • issue24869.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-08-14.17:06:03.418>
labels = ['type-bug', 'library']
title = 'shlex lineno inaccurate with certain inputs'
updated_at = <Date 2017-07-21.10:24:17.291>
user = 'https://bugs.python.org/rescrv'

    bugs.python.org fields:

    activity = <Date 2017-07-21.10:24:17.291>
actor = 'gdr@garethrees.org'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-08-14.17:06:03.418>
creator = 'rescrv'
dependencies = []
files = ['40180', '43361', '46479']
hgrepos = []
issue_num = 24869
keywords = ['patch']
message_count = 6.0
messages = ['248596', '268368', '268454', '268458', '286637', '298792']
nosy_count = 5.0
nosy_names = ['vinay.sajip', 'rescrv', 'petri.lehtinen', 'gdr@garethrees.org', 'hoadlck']
pr_nums = ['2799']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24869'
versions = ['Python 3.5', 'Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.