Make shutil.make_archive have deterministic sorting

Open
#68,653 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with tar-reproducible-testcase.py and the make_archive-stable-ordering.patch attachment, then inspect shutil.make_archive and the related tarfile behavior. Check dependency bpo-30693 before changing the archive ordering. Done means the testcase demonstrates deterministic sorting for shutil.make_archive(format='tar') without leaving recursive tar.add ordering unresolved.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 24465
Nosy @rhettinger, @gustaebel, @bitdancer
Dependencies
  • bpo-30693: tarfile add uses random order
    		•
    Files
  • tar-reproducible-testcase.py: Testcase for stable tar ordering patch
  • tarfile-stable-ordering.patch: Patch to fix issue
  • make_archive-stable-ordering.patch: Patch to make shutil.make_archive(format='tar') determinstic, but not tar.add(recursive=True)
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-06-18.12:14:12.795>
labels = ['type-feature', 'library']
title = 'Make shutil.make_archive have deterministic sorting'
updated_at = <Date 2017-06-18.22:09:51.534>
user = 'https://bugs.python.org/samthursfield'

    bugs.python.org fields:

    activity = <Date 2017-06-18.22:09:51.534>
actor = 'martin.panter'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-06-18.12:14:12.795>
creator = 'samthursfield'
dependencies = ['30693']
files = ['39727', '39728', '39770']
hgrepos = []
issue_num = 24465
keywords = ['patch']
message_count = 9.0
messages = ['245464', '245465', '245466', '245467', '245469', '245493', '245497', '245498', '245628']
nosy_count = 4.0
nosy_names = ['rhettinger', 'lars.gustaebel', 'r.david.murray', 'samthursfield']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24465'
versions = ['Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.