The tarfile module crashes when tarfile contains a symlink and unpack directory contain it too

Open
#67,417 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with tarfile-extract-crash.py to reproduce the symlink collision, then inspect the tarfile module and the possible-fix-23228-with-test2.diff attachment. Compare the existing fix attempts and their test changes; done means the crash is prevented and the regression case passes, including the Windows-specific case in windowserror.diff.

Written by the indexing model from the issue text.

Description

stdlib type-bug
BPO 23228
Nosy @warsaw, @gustaebel, @vadmium, @serhiy-storchaka
Files
  • tarfile-extract-crash.py
  • possible-fix-37688.diff
  • possible-fix-23228-with-test.diff
  • possible-fix-23228-with-test2.diff
  • windowserror.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-01-13.08:55:02.134>
labels = ['type-bug', 'library']
title = 'The tarfile module crashes when tarfile contains a symlink and unpack directory contain it too'
updated_at = <Date 2018-12-16.01:34:29.727>
user = 'https://bugs.python.org/mvo'

    bugs.python.org fields:

    activity = <Date 2018-12-16.01:34:29.727>
actor = 'martin.panter'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-01-13.08:55:02.134>
creator = 'mvo'
dependencies = []
files = ['37688', '37689', '37690', '37774', '42780']
hgrepos = []
issue_num = 23228
keywords = ['patch']
message_count = 9.0
messages = ['233907', '233910', '233914', '233918', '234309', '264808', '265146', '265147', '331911']
nosy_count = 6.0
nosy_names = ['barry', 'lars.gustaebel', 'mvo', 'SilentGhost', 'martin.panter', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23228'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.