python / python/cpython

test_ttk fails with Tk 9.1b1: empty -justify and -anchor are no longer rejected

Open
#157,782 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests topic-tkinter type-bug
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Bug report

With Tk 9.1b1, four tests in test_ttk fail with AssertionError: TclError not raised: EntryTest, ComboboxTest and SpinboxTest.test_configure_justify, and LabelTest.test_configure_anchor.

They check that the empty string is rejected for these options. Since https://core.tcl-lang.org/tk/tktview/aba849a99b the empty string is the default of -justify of ttk::entry, ttk::combobox and ttk::spinbox, and of -anchor of ttk::label, and means the theme default. The change is in Tk 9.1b1 and will be in Tk 9.0.5.

Linked PRs
  • gh-157783
  • gh-157823
  • gh-157824
  • gh-157825

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the test_ttk cases named in the report: EntryTest, ComboboxTest, SpinboxTest.test_configure_justify, and LabelTest.test_configure_anchor. Review how they assert TclError for empty -justify or -anchor values, then run the ttk tests with Tk 9.1b1; done means the affected tests reflect Tk's new default behavior without masking other failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.