IDLE: ScrolledCanvas.zoom_height calls idlelib.zoomheight.zoom_height, which has not existed since 2019
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 77.2k
- Forks
- 35.9k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
Bug report
idlelib.tree.ScrolledCanvas.zoom_height calls a module-level function that has not existed since 2019, so the binding raises as soon as it fires.
Where: Lib/idlelib/tree.py, ScrolledCanvas.zoom_height (line 459 on main), bound to <Alt-2> on the canvas:
def zoom_height(self, event):
zoomheight.zoom_height(self.master)
idlelib/zoomheight.py has had no module-level zoom_height since the Zoom Height rework (gh-81220, PRs #13576 and #13678, 2019): zooming is now ZoomHeight(editwin).zoom_height(), which only reads editwin.top.
Reproduce (3.13.5, but the call is the same on main):
>>> from idlelib import zoomheight
>>> zoomheight.zoom_height
AttributeError: module 'idlelib.zoomheight' has no attribute 'zoom_height'. Did you mean: 'ZoomHeight'?
Pressing Alt-2 in a tree window (Path Browser, Module Browser, the debugger's stack viewer) raises the same AttributeError out of the Tk callback.
Proposed fix — ZoomHeight needs only the toplevel window of what it zooms:
+from types import SimpleNamespace
+
from idlelib import zoomheight
@@
def zoom_height(self, event):
- zoomheight.zoom_height(self.master)
+ # ZoomHeight needs only the toplevel window of what it zooms.
+ top = self.canvas.winfo_toplevel()
+ zoomheight.ZoomHeight(SimpleNamespace(top=top)).zoom_height()
return "break"
Checked by calling ScrolledCanvas.zoom_height from main's sources against a stand-in toplevel: the current code raises AttributeError; the fixed code maximizes the window height (400x300+10+20 -> 400x760+10+0).
If a SimpleNamespace stand-in is not wanted here, ZoomHeight.zoom_height could instead take the toplevel directly; happy to send a PR either way.
Environment: Windows 11, CPython 3.13.5; the line is unchanged on main.
Found while auditing installed code with a verification tool I am building; the reproduction above was run on the version named, and the proposed fix was applied to a local copy and run as well. Report drafted with AI assistance.
Linked PRs
- gh-157772
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit Lib/idlelib/tree.py bei ScrolledCanvas.zoom_height und vergleiche die Implementierung von idlelib/zoomheight.py's ZoomHeight.zoom_height damit. Führe die Alt-2-Aktion in einem Baumfenster aus und überprüfe anschließend, dass der korrigierte Aufruf keinen AttributeError mehr auslöst und das Toplevel-Fenster auf seine Höhe zoomt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- desktop
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 30/100