python / python/cpython

Reduce overhead of PyErr_CheckSignals

未關閉
#157,746 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

interpreter-core performance type-feature
主要語言
Python
星號
77.2k
分支
36k
PR 合併指標
PR 指標待擷取

描述

Feature or enhancement

Proposal:

PyErr_CheckSignals() is the API long-running C loops use to stay interruptible. In the common case (no signal arrived) the call currently does, in order:

  1. _PyRunRemoteDebugger() (since gh-131591, 3.14): a call that fetches the interpreter config via _PyInterpreterState_GetConfig() before looking at the pending flag;
  2. _Py_ThreadCanHandleSignals(): _Py_IsMainThread() calls PyThread_get_thread_ident() and therefore pthread_self(), plus _Py_IsMainInterpreter();
  3. only then _PyErr_CheckSignalsTstate(), whose first line is the cheap is_tripped test that returns immediately.

That is about 100 instructions per call.

Proposal

Test the cheap flags first, without changing what is done when they are set:

  • _PyErr_CheckSignalsTstate() does the main-thread check itself, after its existing is_tripped test, so PyErr_CheckSignals() and the eval loop just call it; the handler-running body moves to an out-of-line helper so the early return stays cheap;
  • _PyRunRemoteDebugger() tests debugger_pending_call before fetching the config.
Results

Non-PGO build, pyperf:

Benchmark main branch
str(12345) 68.6 ns 56.8 ns: 1.21x faster
repr(list(range(100))) 3.06 us 2.36 us: 1.29x faster
', '.join(map(str, range(100))) 6.90 us 5.67 us: 1.22x faster
'%s=%r' % (k, v) 192 ns 177 ns: 1.08x faster
print(*range(100), file=f) 15.6 us 13.5 us: 1.16x faster
csv.writer: 100 rows of 10 ints 72.5 us 60.1 us: 1.21x faster
repr(dataclass with 5 fields) 805 ns 720 ns: 1.12x faster
a * b (10 x 10 digits) 159 ns 102 ns: 1.56x faster
a // c (10 // 2 digits) 151 ns 121 ns: 1.24x faster

Notes: the gain for the arithmetic cases are not too important, they can be handled directly as well. See https://github.com/python/cpython/issues/157742.

Has this already been discussed elsewhere?

Related: gh-131591, gh-133465

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
  • gh-157748

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

先閱讀 PyErr_CheckSignals()、_PyErr_CheckSignalsTstate() 和 _PyRunRemoteDebugger(),著重於所述的低成本 flag 檢查與訊號處理順序。將提議的行為與基準測試和連結的 PR gh-157748 進行比較;當無訊號路徑的成本更低,且在設定 flag 時不改變行為時,該 issue 即完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
c, python
領域
performance
Issue 類型
功能
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
描述清楚
新手友好度
25/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。