Windows debug abi3t extensions autolink python316_d.lib instead of python316t_d.lib
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
On the current main branch, an MSVC-compatible debug extension that defines
Py_LIMITED_API and Py_TARGET_ABI3T can select the ordinary debug import
library instead of the free-threaded debug library.
The ordering in the public headers appears to cause the mismatch:
PC/pyconfig.hselects the autolink library.- Only later does
Include/pyabi.hderivePy_GIL_DISABLEDfrom
Py_TARGET_ABI3T.
The debug autolink branch in PC/pyconfig.h currently checks only
Py_GIL_DISABLED. An abi3t extension identifies its target with
Py_TARGET_ABI3T, so it does not necessarily define Py_GIL_DISABLED before
including these headers.
I reproduced this by compiling a minimal Windows x86-64 COFF object with Clang
in MSVC-compatible target mode. The probe defines _DEBUG, Py_LIMITED_API,
and Py_TARGET_ABI3T=0x030f0000, then includes the two headers in their normal
order:
#include "PC/pyconfig.h"
#include "Include/pyabi.h"
#ifndef Py_GIL_DISABLED
# error "Py_TARGET_ABI3T did not enable Py_GIL_DISABLED"
#endif
int cpython_abi3t_autolink_probe;
The resulting object's .drectve section contains:
/DEFAULTLIB:python316_d.lib
Defining Py_GIL_DISABLED explicitly before including the headers instead
produces:
/DEFAULTLIB:python316t_d.lib
The release abi3t case already selects python3t.lib; the mismatch is specific
to the versioned debug-library branch. The PCbuild naming also identifies
python316t_d.lib as the free-threaded debug import library.
A minimal possible fix is to recognize the ABI target at the point where the
autolink library is selected:
-#if defined(Py_GIL_DISABLED)
+#if defined(Py_GIL_DISABLED) || defined(Py_TARGET_ABI3T)
With that change, the original probe, without an explicit
Py_GIL_DISABLED, emits /DEFAULTLIB:python316t_d.lib.
This test inspects the Windows linker directive emitted by the public headers,
but I have not run a native Windows extension build. Could you confirm whether
Py_TARGET_ABI3T should select the free-threaded debug import library at this
earlier point? If so, I can prepare a pull request with this change, or adjust
it if changing the include/derivation order is preferred.
CPython versions tested on
CPython main.
Operating systems tested on
The reproducer was cross-compiled on Linux for the Windows x86-64 MSVC target.
Native Windows validation has not yet been performed -- as I do not have a windows machine.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
- gh-157623
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 PC/pyconfig.h 中的 autolink 选择和 Include/pyabi.h 中的 ABI 推导开始。重现文档化的 probe,或检查链接的 PR gh-157623,然后验证 Windows debug abi3t 情况会发出 free-threaded 导入库指令,而不要求显式的 Py_GIL_DISABLED。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, python
- 领域
- build-system, operating-systems
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100