AArch64 JIT trampoline clobbers x8
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
While auditing the indirect branches the JIT emits on AArch64 for BTI compatibility (part of investigating gh-149697), I noticed that the trampoline for calls out of range of a bl (patch_aarch64_trampoline in Python/jit.c) is:
ldr x8, 8
br x8
The AAPCS64 only allows a veneer to alter x16, x17 and the flags, which is why the linkers' own long-branch stubs use x16. x8 carries the address of the result buffer when the callee returns a struct too large for registers, so a callee reached through this trampoline would store its result through the trampoline's target address instead.
THere is no helper at the moment where a JIT call would return such a struct but a standalone program calling a function that returns a 32-byte struct through the same 16 bytes segfaults with x8 and works with x16. A simple reproducer:
#include <stdio.h>
typedef struct { long a, b, c, d; } big; /* returned through x8 */
big make_big(long x) { return (big){x, x + 1, x + 2, x + 3}; }
/* trampolines */
__asm__(
"via_x8: ldr x8, 1f\n br x8\n 1: .xword make_big\n"
"via_x16: ldr x16, 2f\n br x16\n 2: .xword make_big\n"
);
big via_x8(long), via_x16(long);
int main(void)
{
big r = via_x16(40);
printf("via x16: %ld %ld %ld %ld\n", r.a, r.b, r.c, r.d);
fflush(stdout);
r = via_x8(40);
printf("via x8: %ld %ld %ld %ld\n", r.a, r.b, r.c, r.d);
}
$ gcc -O2 -g repro.c && ./a.out
via x16: 40 41 42 43
Segmentation fault (core dumped)
Using x16 also makes the br acceptable to a BTI C landing pad once JIT memory is mapped with PROT_BTI, which the linkers' stubs already satisfy.
Introduced in gh-119726.
cc @diegorusso
CPython versions tested on:
CPython main branch, 3.16, 3.15, 3.14
Operating systems tested on:
Linux
Linked PRs
- gh-157527
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Python/jit.c 中的 patch_aarch64_trampoline 开始,然后运行提供的 AArch64 C 复现程序以观察 x8 失败。检查报告中描述的 AAPCS64 和 BTI 约束;完成的标准是 trampoline 不再覆盖大结构体结果缓冲区寄存器,并且复现程序成功运行。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, python
- 领域
- compilers
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 35/100