NameError: Value not defined in two threads-only pool tests when ctypes is unavailable
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
In Lib/test/_test_multiprocessing.py, both
test_imap_and_imap_unordered_when_buffer_is_full and
test_imap_and_imap_unordered_with_buffersize_when_buffer_is_full create a
shared value with a module-level Value:
last_produced_task_arg = Value("i")
But Value is only conditionally imported at the top of the module:
try:
from multiprocessing.sharedctypes import Value, copy
HAS_SHAREDCTYPES = True
except ImportError:
HAS_SHAREDCTYPES = False
So when ctypes/sharedctypes are unavailable (HAS_SHAREDCTYPES == False), the
name Value is undefined. Unlike the other sharedctypes-based tests in this
file (which use @unittest.skipUnless(HAS_SHAREDCTYPES, ...)), these two tests
have no such guard, so they run and raise:
NameError: name 'Value' is not defined. Did you mean: 'self.Value'?
Reproduced in verbose mode as 4 errors (2 tests x {imap, imap_unordered})
when running test_multiprocessing_forkserver.test_threads on a build without
ctypes.
These tests are threads-only (they call skipTest() for other backends), so
self.Value resolves to multiprocessing.dummy.Value and does not depend on
ctypes. Replacing Value("i") with self.Value("i", 0):
- fixes the NameError on builds without ctypes, and
- matches how the rest of the suite creates shared values. Since both
forms initialize the value to zero, there is no behavior change when
ctypes is available.
Proposed fix:
- last_produced_task_arg = Value("i")
+ last_produced_task_arg = self.Value("i", 0)
This is my first contribution to CPython. I used Claude and opencode to help
me understand the codebase, and vim to edit the file. I reviewed and tested
the change myself; please let me know if I missed any process step
Linked PRs
- gh-155333
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza en Lib/test/_test_multiprocessing.py e inspecciona test_imap_and_imap_unordered_when_buffer_is_full y test_imap_and_imap_unordered_with_buffersize_when_buffer_is_full. Ejecuta test_multiprocessing_forkserver.test_threads en una compilación sin ctypes; se considera terminado cuando ambas pruebas evitan el NameError y la ejecución de pruebas finaliza correctamente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- testing
- Tipo de issue
- Error
- Dificultad
- 1/5
- Tiempo estimado
- Menos de una hora
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 25/100