python / python/cpython

Python.h conflicts with stdlib.h if included after that

Abierto
#155,321 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

build type-bug
Lenguaje dominante
Python
Estrellas
77.2k
Forks
35.9k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

Bug report

Bug description:

Issue: Inconsistent _POSIX_C_SOURCE definition causes compilation errors when Python.h is included after system headers

Environment:

  • Fedora 44
  • CPython 3.14 (distro-provided packages)
  • Go 1.26 with CGo

Description:

When Python.h is included after system headers such as stdlib.h, a compilation error occurs due to conflicting definitions of the _POSIX_C_SOURCE macro. The conflict arises because:

  • Python.h indirectly defines _POSIX_C_SOURCE via its inclusion of pyconfig-64.h (located at /usr/include/python3.14/pyconfig-64.h)
  • System headers like stdlib.h also define _POSIX_C_SOURCE via their inclusion of /usr/include/features.h
  • The two definitions differ, triggering a compiler diagnostic

Context:

While the official CPython documentation recommends including Python.h before any other headers, this is not always feasible. In my specific use case, I'm using the libpython3.so shared library from Go via CGo. The CGo toolchain automatically generates a C helper file that puts #include <stdlib.h> before any user-provided code, making it impossible to adhere to the "include Python.h first" recommendation.

Current workaround:

I'm currently using #undef _POSIX_C_SOURCE immediately before including Python.h:

#undef _POSIX_C_SOURCE
#include <Python.h>

However, this approach is fragile and potentially unsafe, as it may cause system headers to be compiled with different _POSIX_C_SOURCE values across translation units, leading to subtle ABI mismatches or undefined behavior.

Proposed fix:

Modify the generated pyconfig-*.h files to guard the _POSIX_C_SOURCE definition with #ifndef/#endif preprocessor directives, similar to how other feature test macros are often handled:

#ifndef _POSIX_C_SOURCE
#define _POSIX_C_SOURCE 200809L  /* or whatever version is currently used */
#endif

This change would make the definition idempotent and prevent compilation errors regardless of include order, while maintaining the intended feature test macro settings.

Impact:

This issue affects any project that:

  • Uses CPython's C API
  • Cannot control the include order of system headers (e.g., via CGo, SWIG, or other binding generators)
  • Builds on platforms where _POSIX_C_SOURCE is defined by system headers

Cc: @sobolevn

CPython versions tested on:

3.14

Operating systems tested on:

Linux

Linked PRs
  • gh-155343

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza revisando el PR vinculado en el issue, gh-155343, y los archivos pyconfig-*.h generados que intervienen en la definición de _POSIX_C_SOURCE. Compara cómo se comporta Python.h cuando se incluye después de stdlib.h y, a continuación, usa la configuración indicada de Fedora 44 y CPython 3.14 para reproducir el error de compilación. Se considera terminado cuando el caso de include-order ya no produce diagnósticos de macros en conflicto sin introducir configuraciones inconsistentes de feature-test.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
c, python
Área
build-system
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.