Crash in genericaliasobject.c when tuple_extend() fails under allocation failure
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Crash report
What happened?
While investigating allocation-failure paths in Objects/genericaliasobject.c, I found a NULL dereference in subs_tvars().
When tuple_extend() fails, it returns -1 after _PyTuple_Resize() fails. _PyTuple_Resize() clears its out-parameter (*pv = NULL) on failure, so subargs is guaranteed to be NULL.
However, subs_tvars() unconditionally calls:
if (j < 0) {
Py_DECREF(subparams);
Py_DECREF(subargs);
return NULL;
}
As a result, Py_DECREF(subargs) dereferences a NULL pointer and crashes the interpreter instead of propagating the MemoryError.
Reproducer
A debug build with _testcapi is required.
import _testcapi
from typing import TypeVarTuple
Ts = TypeVarTuple("Ts")
alias = dict[str, tuple[*Ts]]
key = (int, str)
_testcapi.set_nomemory(24, 25)
try:
alias[key]
finally:
_testcapi.remove_mem_hooks()
The exact allocation index may vary between builds, so sweeping a range of indices is recommended.
Observed result
ASan reports:
AddressSanitizer: SEGV on unknown address 0x000000000000
#0 _Py_IsImmortal
#1 Py_DECREF
#2 subs_tvars (Objects/genericaliasobject.c)
#3 _Py_subs_parameters
#4 ga_getitem
Root cause
tuple_extend() immediately returns -1 when _PyTuple_Resize() fails. _PyTuple_Resize() sets its out-parameter to NULL on failure, so subargs is guaranteed to be NULL when control reaches the error path. Calling Py_DECREF(subargs) therefore dereferences a NULL pointer.
The issue appears related to gh-148222, which removed the same Py_DECREF() pattern from _Py_make_parameters() after _PyTuple_Resize() failure, but this analogous path in subs_tvars() remained unchanged.
Removing Py_DECREF(subargs); causes the reproducer to raise MemoryError instead of crashing.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Output from running 'python -VV' on the command line:
Python 3.16.0a0 (heads/investigate-genericalias-oom-null-decref-dirty:7ce7f0bd851, Aug 1 2026) [GCC 13.3.0]
Linked PRs
- gh-155055
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 Objects/genericaliasobject.c 中的 subs_tvars() 和 tuple_extend() 開始,然後在偵錯組建上執行提供的 _testcapi 配置失敗重現程式。確認失敗路徑不再崩潰並傳播 MemoryError;比較 _Py_make_parameters() 中的類似處理,並檢查相關的 gh-155055 工作。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- c, python
- 領域
- backend
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100