python / python/cpython

IDLE - Update mousewheel event handling

Open
#154,511 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stdlib topic-IDLE type-refactor
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Followup to gh-153741 which made IDLE aware of x11 wheel event change in 8.7 and 9.0. Move definition of x11_buttons from test_sidebar to util. Move def wheel_event from tree to util and move its test from test_tree to test_util. (I expect tree.py to eventially be replaced by ttk.treeview.) Make various other adjustments

There are unneeded bindings of buttons 4 and 5 in sidebar. We might be able to handle the needed binding with wheel_event with a second argument. I will leave this for a second PR.

Linked PRs
  • gh-154512
  • gh-156974
  • gh-157021
  • gh-157022
  • gh-157023

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with idlelib/sidebar.py, idlelib/tree.py, idlelib/util.py, and the tests in idlelib/idle_test/test_sidebar.py, idlelib/idle_test/test_tree.py, and idlelib/idle_test/test_util.py. Review the linked PRs first, since the work has already been divided across them. Done means the named definitions and test are relocated and the remaining adjustments are covered without breaking the relevant IDLE tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.