Cross-interpreter memory leak in _xidata_release when originating interpreter is destroyed
Personne n'a encore pris cette issue.
- Langage dominant
- Python
- Étoiles
- 77.2k
- Forks
- 35.9k
- Métriques de merge des PR
- Métriques de PR en attente
Description
Bug report
Bug description:
Bug report
Bug summary
There is a known memory leak in Python/crossinterp.c related to the teardown of sub-interpreters when they share data.
When a sub-interpreter packages data into _PyXIData_t and passes it to a receiving interpreter, the receiver is expected to call _PyXIData_Release to free it. However, if the originating interpreter is destroyed before the receiver calls release, the original interpreter's memory context is lost.
In _xidata_release (Python/crossinterp.c around line 1049), the code correctly identifies this state:
PyInterpreterState *interp = _PyInterpreterState_LookUpID(
_PyXIData_INTERPID(xidata));
if (interp == NULL) {
// The interpreter was already destroyed.
// This function shouldn't have been called.
// XXX Someone leaked some memory...
Because the originating interpreter is gone, Python intentionally leaks xidata->obj to avoid a use-after-free segfault.
Proposed Solution Architecture
To resolve this without crashing, we would need to track cross-interpreter data at the interpreter level:
- Modify
PyInterpreterStateto include a thread-safe registry tracking all active_PyXIData_tinstances created by that interpreter. - Register instances during
_PyCode_GetXIDataand deregister them during_xidata_release. - Modify
Py_EndInterpreterteardown to check this registry. If outstanding shared data exists, the shutting-down interpreter must either block until it is released, or forcefully invalidate/free the shared data (using anis_invalidatedflag) before tearing down its ownobmallocstate.
I'm opening this issue to get feedback on the proposed architecture before starting a Pull Request.
CPython versions tested on:
main branch
CPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Linked PRs
- gh-153745
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par Python/crossinterp.c autour de _xidata_release, puis suivez _PyCode_GetXIData et le chemin de destruction de Py_EndInterpreter. Consultez le travail lié gh-153745 avant de poursuivre, car cette issue demande un retour architectural et ne définit ni implémentation arrêtée ni test de complétion.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- c, python
- Domaine
- backend
- Type d'issue
- Bug
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100