IDLE module-name completion crashes on a non-iterable __all__
@terryjreedy 已经在做这个了。
开始于 2026年7月12日。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
When the IDLE shell namespace has a non-iterable __all__ (for example __all__ = None, an easy typo), pressing Tab for module-name completion at an empty prefix raises an uncaught TypeError instead of showing completions.
autocomplete.AutoComplete.fetch_completions handles the ATTRS empty-prefix case with sorted(eval("__all__", namespace)) and no guard, while the sibling non-empty-prefix branch already wraps the equivalent sorted(entity.__all__) in try/except and returns empty lists on failure. Only the empty-prefix branch is affected.
Reproduction in the IDLE shell:
>>> __all__ = None
>>> # press Tab at an empty prefix
TypeError: 'NoneType' object is not iterable
A deterministic regression test that drives fetch_completions with a patched __main__.__all__ is included in the linked PR.
Suggested fix: guard the empty-prefix branch the same way the sibling branch is guarded, returning empty completion lists when __all__ cannot be evaluated or sorted.
CPython versions tested on:
3.16, CPython main branch
Operating systems tested on:
macOS
Linked PRs
- gh-153507
- gh-153527
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。