Detect foreign content in HTMLParser for context-dependent parsing of CDATA sections
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Feature or enhancement
HTMLParser recognizes a CDATA section <![CDATA[...]]> in any context. According to the HTML5 specification, it should only be recognized in foreign content -- the content of svg and math elements. Otherwise <![CDATA[ starts a bogus comment which ends at the first >, not at ]]>. Using the wrong ending condition can make the parser see a different structure of the document than browsers, which can have security consequences. This is the last unresolved item of gh-135661. The fix in #135665 was not satisfying, it just passed the ball to the user's side: the user is supposed to maintain the tracking mechanism outside of HTMLParser and call the new private method _set_support_cdata().
I propose to automatically detect foreign content in HTMLParser itself, by following start and end tags, approximating the tree construction dispatcher and the rules for parsing tokens in foreign content.
>>> parser.feed('<![CDATA[a > b]]>') # bogus comment: comment '[CDATA[a '
>>> parser.feed('<svg><![CDATA[a > b]]>') # CDATA section: unknown decl 'CDATA[a > b'
This also fixes RAWTEXT and RCDATA elements in foreign content: <svg><title>a<b>c</b></title> contains a b element, but HTMLParser currently parses the title content as text.
The new constructor parameter support_cdata controls this: None (default) -- automatic detection; True -- a CDATA section is recognized in any context, foreign content is not detected (the previous default behavior); False -- a CDATA section is never recognized. Calling _set_support_cdata() disables the automatic detection, so existing code which maintains its own tracking machinery works as before.
Has this already been discussed elsewhere?
The last item of gh-135661, discussed also in #135665. Related: gh-137877, gh-140878.
Links to previous discussion of this feature:
Linked PRs
- gh-153028
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 HTMLParser、其构造函数、feed() 和 _set_support_cdata() 开始,然后将提议的行为与链接的 HTML5 树构建和 foreign-content 规则进行比较。完成标准是 support_cdata 默认为自动上下文检测,而 True、False 以及现有的 _set_support_cdata() 行为符合所述的兼容性情形,包括 CDATA 和 RAWTEXT/RCDATA 示例。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- web-dev
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100