Order-dependent failure: test_profiling CLI test fails after test_importlib.test_util
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
Summary
I found an order-dependent test failure on current main.
A test_profiling sampling CLI test passes when run alone, but fails when run after test_importlib.test_util.
Environment
- OS: Windows NT 10.0.26200.0
- CPython commit:
449122ed0dbdb6a545af4927c59f4c80ee15c515 - Debug build:
PCbuild\amd64\python_d.exe - Release build: also reproduced
- Branch:
investigate/deep-cpython-bug-hunt
Reproduction
PCbuild\amd64\python_d.exe -m unittest -v test.test_importlib.test_util test.test_profiling.test_sampling_profiler.test_cli.TestSampleProfilerCLI.test_cli_module_argument_parsing
The same profiling test passes when run alone.
Actual behavior
The test fails with:
profiling.sampling.errors.SamplingModuleNotFoundError: Module 'mymodule' not found.
Expected behavior
The profiling CLI test should pass regardless of whether test_importlib.test_util ran earlier in the same process.
Investigation
The profiling CLI test patches:
importlib.util.find_spec
However, after running test_importlib.test_util, importlib.util and sys.modules["importlib.util"] appear to refer to different module objects.
The CLI code calls through its own imported module reference:
profiling.sampling.cli.importlib.util.find_spec
So the mock on the global importlib.util.find_spec does not intercept the lookup, and the CLI tries to resolve the fake module name normally.
That leads to:
SamplingModuleNotFoundError: Module 'mymodule' not found.
I could not find an existing open issue or PR covering this failure.
Possible fix
The smallest fix may be to patch the symbol at the point where it is used, for example:
profiling.sampling.cli.importlib.util.find_spec
inside the profiling CLI tests, or alternatively to avoid this mock by using a real temporary module.
I am happy to prepare a focused test-only PR if that direction sounds reasonable.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Linked PRs
- gh-152675
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
先從 test.test_importlib.test_util 和 test.test_profiling.test_sampling_profiler.test_cli.TestSampleProfilerCLI.test_cli_module_argument_parsing 開始,然後在 Windows 上執行回報的 unittest 命令。檢查 mock 目標是否與 profiling.sampling.cli 使用的模組參照相符。CLI 測試能單獨通過,且在 test_importlib.test_util 之後也能通過,即表示完成;查看連結的 PR gh-152675 了解目前的工作。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- testing-qa
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100