Make perf_trampoline thread safe.
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
We are using an internal profiler that relies on perf_trampoline to associate Python frames with native samples. The current implementation is incompatible with free-threading, leading to data races and crashes when we enabled Tsan and used the profiler in highly concurrent environments. This proposal aims to bridge that gap and enable profiler support for free-threading builds by fixing data races, deadlocks, and memory lifecycle edge cases in perf_trampoline.c.
ThreadSanitizer (TSan) Data Race Report
The following data race was captured during concurrent execution under Free Threading and Tsan. Note that the following stack trace has been sanitized to remove internal organization details and the critical data race in perf_trampoline.c should remain represented:
==================
WARNING: ThreadSanitizer: data race (pid=6355)
Read of size 8 at 0x720c009e2428 by thread T2:
#0 compile_trampoline Python/perf_trampoline.c:413:27
#1 py_trampoline_evaluator Python/perf_trampoline.c:437:40
#2 _PyEval_EvalFrame Include/internal/pycore_ceval.h:122:12
#3 _PyEval_Vector Python/ceval.c:2094:12
#4 _PyFunction_Vectorcall Objects/call.c:380:12
... [generic interpreter evaluation frames] ...
#10 thread_run Modules/_threadmodule.c:359:21
#11 pythread_wrapper Python/thread_pthread.h:242:5
Previous write of size 8 at 0x720c009e2428 by main thread:
#0 code_arena_new_code Python/perf_trampoline.c:403:27
#1 compile_trampoline Python/perf_trampoline.c:419:12
#2 py_trampoline_evaluator Python/perf_trampoline.c:437:40
#3 _PyEval_EvalFrame Include/internal/pycore_ceval.h:122:12
#4 _PyEval_Vector Python/ceval.c:2094:12
... [generic interpreter evaluation frames] ...
#15 _PyEval_EvalFrameDefault Python/generated_cases.c.h:1622:35
==================
I have searched the existing issues for similar reports but was unable to find any duplicates. Please let me know if this has already been reported!
CPython versions tested on:
3.14
Operating systems tested on:
Linux
Linked PRs
- gh-152331
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Python/perf_trampoline.c 以及 compile_trampoline 和 code_arena_new_code 周围报告的 TSan 堆栈跟踪开始。进行更改之前,检查链接的 PR gh-152331 和现有的 free-threading 行为。完成的标准是 perf_trampoline 支持所报告的并发 profiler 场景,且不存在所报告的 Races、Deadlocks 或生命周期故障。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- backend, devtools
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100