Data race in `faulthandler.enable()` and `faulthandler.disable()` with free-threading
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
faulthandler.enable() and faulthandler.disable() read and write the global fatal_error state with no synchronization. enable() checks the enabled guard and then sets it,
while disable() reads the same guard and tears the state back down, including Py_CLEAR(fatal_error.file),
so two threads calling enable() and disable() concurrently race on the enabled flag, on the installed signal handlers, and on the fatal_error.file reference.
Reproducer:
import faulthandler, os
from threading import Thread, Event
def owner():
f = open(os.devnull, 'w')
for _ in range(200000):
faulthandler.enable(file=f, all_threads=False)
f.write('x')
f.flush()
f.close()
def toggler():
for _ in range(200000):
faulthandler.disable()
threads = [Thread(target=owner) for _ in range(4)]
threads += [Thread(target=toggler) for _ in range(4)]
for t in threads: t.start()
for t in threads: t.join()
With TSAN build, the owner thread's own f.write()/enable() raises ValueError: I/O operation on uninitialized object because a concurrent disable() dropped the last reference to f and finalized it.
TSAN Report:
WARNING: ThreadSanitizer: data race (pid=1671402)
Write of size 4 at 0x555555e19478 by thread T5:
#0 faulthandler_disable /cpython/./Modules/faulthandler.c:644:29 (python3.16t+0x57830e)
#1 faulthandler_disable_py_impl /cpython/./Modules/faulthandler.c:674:5
#2 faulthandler_disable_py /cpython/./Modules/clinic/faulthandler.c.h:299:12
#3 cfunction_vectorcall_NOARGS /cpython/Objects/methodobject.c:508:24
#4 _PyObject_VectorcallTstate /cpython/./Include/internal/pycore_call.h:144:11
#5 PyObject_Vectorcall /cpython/Objects/call.c:327:12
...
Previous read of size 4 at 0x555555e19478 by thread T4:
#0 faulthandler_enable /cpython/./Modules/faulthandler.c:538:21
#1 faulthandler_py_enable_impl /cpython/./Modules/faulthandler.c:633:9
#2 faulthandler_py_enable /cpython/./Modules/clinic/faulthandler.c.h:278:20
#3 cfunction_vectorcall_FASTCALL_KEYWORDS /cpython/Objects/methodobject.c:465:24
#4 _PyObject_VectorcallTstate /cpython/./Include/internal/pycore_call.h:144:11
#5 PyObject_Vectorcall /cpython/Objects/call.c:327:12
...
Location is global '_PyRuntime' of size 405824 at 0x555555e16c80
SUMMARY: ThreadSanitizer: data race /cpython/./Modules/faulthandler.c:644:29 in faulthandler_disable
==================
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Modules/faulthandler.c 中 enable() 的第 536-541 行和 disable() 的第 641-658 行开始,然后使用 ThreadSanitizer 构建运行提供的复现程序。跟踪共享的 enabled 状态、信号处理程序以及 fatal_error.file 的所有权;当并发调用 enable()/disable() 不再产生报告中的 race,也不再使调用者的文件失效时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- operating-systems
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 46/100