Optimize int add/sub for wide exact ints
未关闭
还没有人认领这个 Issue。
interpreter-core
performance
type-feature
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
CPython has a fast path for compact integers in binary add/sub, but wide exact ints still go through the generic long arithmetic path even when both operands fit in int64_t.
This issue proposes adding a separate fast path for exact PyLong operands that fit in signed 64-bit integers, while preserving the existing compact-int path.
Suggested implementation:
- Keep the current compact-int specialization unchanged.
- Add a separate wide-int path for exact ints that fit in int64_t.
- Preserve current behavior for overflow, subclasses, and other non-exact-int cases.
Motivation:
- Improve performance for wide integer add/sub without affecting the common compact-int hot path.
- Avoid adding new opcodes in the compact-int path.
- Fit within the current interpreter and specialization structure.
Benchmark evidence:
- I prototyped this locally with a benchmark covering compact and wide add/sub cases.
- Wide cases improved substantially, while compact cases remained effectively flat.
- Representative interpreter-only results with JIT disabled:
- add_wide: about 25% faster
- sub_wide: about 35% faster
- add_compact/sub_compact: effectively unchanged
Benchmark script used locally:
"""Microbenchmark compact vs wide int add/sub with pyperf.
Use this with PYTHON_JIT=0 and -S if you want a stable interpreter-only run:
PYTHON_JIT=0 ./python.exe -S Tools/scripts/bench_wide_int_pyperf.py
"""
from __future__ import annotations
import pyperf
def bench_add_compact() -> int:
a = 1
b = 2
return a + b
def bench_add_wide() -> int:
a = 10_000_000_000
b = 1
return a + b
def bench_sub_compact() -> int:
a = 1
b = 2
return a - b
def bench_sub_wide() -> int:
a = 10_000_000_000
b = 1
return a - b
def main() -> None:
runner = pyperf.Runner()
runner.bench_func("add_compact", bench_add_compact)
runner.bench_func("add_wide", bench_add_wide)
runner.bench_func("sub_compact", bench_sub_compact)
runner.bench_func("sub_wide", bench_sub_wide)
if __name__ == "__main__":
main()
Linked PRs
- gh-151290
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先查看关联的 PR gh-151290,然后检查 issue 中描述的解释器特化结构。使用 PYTHON_JIT=0 和 -S 运行 Tools/scripts/bench_wide_int_pyperf.py,以比较 compact 和 wide 的 add/sub 情况。完成的标准是:兼容 int64 的 wide 操作数使用 fast path,同时 compact、overflow、subclass 和 non-exact-int 的行为保持不变。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- performance
- Issue 类型
- 重构
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100