python / python/cpython

Many places have missing `PyErr_NoMemory()` call after failing memory allocation

未關閉
#151,126 2 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@sobolevn 已經在處理了。

開始於 2026年6月9日。

interpreter-core type-crash
主要語言
Python
星號
77.2k
分支
36k
PR 合併指標
PR 指標待擷取

描述

Crash report

  1. remove_unused_consts in Python/flowgraph.c

When PyMem_Malloc(nconsts * sizeof(Py_ssize_t)); fails, we need to set an exception.

https://github.com/python/cpython/blob/29a920e80e21490b5bdb7178373f80fe606a4403/Python/flowgraph.c#L3267-L3283

  1. gethandlelist and getattributelist in _winapi.c

This place misses it:

https://github.com/python/cpython/blob/9fdbade99e6bcc607d9f12416bfca5bbf94022b9/Modules/_winapi.c#L1196-L1198

All other error paths set exceptions, except this if:

https://github.com/python/cpython/blob/9fdbade99e6bcc607d9f12416bfca5bbf94022b9/Modules/_winapi.c#L1278-L1282

  1. _channelends_new in Modules/_interpchannelsmodule.c

https://github.com/python/cpython/blob/3ca93ab198497da9451101019b67c52e7873377d/Modules/_interpchannelsmodule.c#L920-L926

Later we check for errors in handle_channel_error, it requires either setting err to non -1 or to set Python exception. Both are false, it fails with the assertion failure.

Linked PRs
  • gh-151127
  • gh-151134
  • gh-151135
  • gh-151136
  • gh-151137
  • gh-151154
  • gh-151180
  • gh-151181
  • gh-151182
  • gh-151239
  • gh-151265
  • gh-151266
  • gh-151336
  • gh-151338
  • gh-151339
  • gh-151360
  • gh-151361
  • gh-151362
  • gh-151382
  • gh-151398
  • gh-151399
  • gh-151400
  • gh-151580
  • gh-151582
  • gh-151588
  • gh-151590
  • gh-151624
  • gh-151639
  • gh-152014
  • gh-152015
  • gh-152016
  • gh-152169
  • gh-152170
  • gh-152177
  • gh-152179
  • gh-152180
  • gh-152181
  • gh-152182
  • gh-152183
  • gh-152184
  • gh-152418
  • gh-152420
  • gh-152421
  • gh-152422
  • gh-152478
  • gh-152677
  • gh-152678
  • gh-152720
  • gh-153215
  • gh-153708
  • gh-153709
  • gh-153710
  • gh-153765
  • gh-156292
  • gh-156299
  • gh-156301

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。