Inconsistent handling of the modulo argument for ternary pow() (pure-Python vs extension)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 35.9k
- PR merge metrics
- PR metrics pending
Description
Bug report
Bug description:
This is a follow-up of the https://github.com/python/cpython/issues/130104.
An example with the stdlib:
>>> import decimal, _pydecimal
>>> pow(2, 3, decimal.Decimal(4))
Decimal('0')
>>> pow(2, 3, _pydecimal.Decimal(4))
Traceback (most recent call last):
File "<python-input-5>", line 1, in <module>
pow(2, 3, _pydecimal.Decimal(4))
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: unsupported operand type(s) for ** or pow(): 'int', 'int', 'Decimal'
IIUIC, pow() it just calls the __pow__() for the third argument with original order of ops as a fallback. So, we can just do something like this:
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 14bc5a4bc4..911c890fcb 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -10377,7 +10377,27 @@ slot_nb_power(PyObject *self, PyObject *other, PyObject *modulus)
stack[2] = modulus;
return vectorcall_maybe(tstate, &_Py_ID(__rpow__), stack, 3);
}
- Py_RETURN_NOTIMPLEMENTED;
+ stack[0] = self;
+ stack[1] = other;
+ stack[2] = modulus;
+
+ _PyCStackRef cref;
+ _PyThreadState_PushCStackRef(tstate, &cref);
+ int unbound = lookup_maybe_method(modulus, &_Py_ID(__pow__), &cref.ref);
+ PyObject *func = PyStackRef_AsPyObjectBorrow(cref.ref);
+
+ if (func == NULL) {
+ _PyThreadState_PopCStackRef(tstate, &cref);
+ if (!PyErr_Occurred()) {
+ Py_RETURN_NOTIMPLEMENTED;
+ }
+ return NULL;
+ }
+
+ PyObject *retval = vectorcall_unbound(tstate, unbound, func, stack, 3);
+
+ _PyThreadState_PopCStackRef(tstate, &cref);
+ return retval;
}
SLOT0(slot_nb_negative, __neg__)
Full patch: https://github.com/skirpichev/cpython/pull/9
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Objects/typeobject.c at slot_nb_power and reproduce the decimal/_pydecimal examples from the report on a CPython main build. Compare ternary pow() behavior between the pure-Python and extension implementations; done means both handle the modulo argument consistently without regressing existing fallback behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, python
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100